Tweak error messages

Author: FrederikBolding

packages/snaps-controllers/src/services/AbstractExecutionService.test.ts

@@ -81,7 +81,7 @@ describe('AbstractExecutionService', () => {
         endowments: ['console'],
       }),
     ).rejects.toThrow(
-      `The executor for npm:@metamask/example-snap couldn't start initialization.`,
+      `The executor for npm:@metamask/example-snap couldn't start initialization. The offscreen document may not exist.`,
     );
   });
 
@@ -105,7 +105,7 @@ describe('AbstractExecutionService', () => {
         endowments: ['console'],
       }),
     ).rejects.toThrow(
-      'The executor for npm:@metamask/example-snap failed to initialize.',
+      'The executor for npm:@metamask/example-snap failed to initialize. The iframe/webview/worker failed to load.',
     );
   });
 

packages/snaps-controllers/src/services/AbstractExecutionService.ts

@@ -265,16 +265,14 @@ export abstract class AbstractExecutionService<WorkerType>
 
       const status = this.#status.get(snapId);
       if (status === 'created') {
+        // Currently this error can only be thrown by OffscreenExecutionService.
         throw new Error(
-          `The executor for ${snapId} couldn't start initialization.`,
+          `The executor for ${snapId} couldn't start initialization. The offscreen document may not exist.`,
         );
       }
-
-      if (status === 'initializing') {
-        throw new Error(`The executor for ${snapId} failed to initialize.`);
-      }
-
-      throw new Error(`The executor for ${snapId} was unreachable.`);
+      throw new Error(
+        `The executor for ${snapId} failed to initialize. The iframe/webview/worker failed to load.`,
+      );
     }
 
     const { worker, stream: envStream } = result;
@@ -392,7 +390,9 @@ export abstract class AbstractExecutionService<WorkerType>
       );
 
       if (pingResult === hasTimedOut) {
-        throw new Error(`The executor for ${snapId} was unreachable.`);
+        throw new Error(
+          `The executor for ${snapId} was unreachable. The executor did not respond in time.`,
+        );
       }
     }