Add error handling for MetaMetrics hook

Author: david0xd

packages/snaps-controllers/src/snaps/SnapController.test.tsx

@@ -9522,6 +9522,52 @@ describe('SnapController', () => {
         expect(mockTrackEvent).not.toHaveBeenCalled();
         snapController.destroy();
       });
+
+      it('should properly handle error when MetaMetrics hook throws an error', async () => {
+        const log = jest.spyOn(console, 'error').mockImplementation();
+        const error = new Error('MetaMetrics hook error');
+        const mockTrackEvent = jest.fn().mockImplementation(() => {
+          throw error;
+        });
+        const rootMessenger = getControllerMessenger();
+        const executionEnvironmentStub = new ExecutionEnvironmentStub(
+          getNodeEESMessenger(rootMessenger),
+        ) as unknown as NodeThreadExecutionService;
+
+        const [snapController] = getSnapControllerWithEES(
+          getSnapControllerWithEESOptions({
+            rootMessenger,
+            trackEvent: mockTrackEvent,
+            state: {
+              snaps: getPersistedSnapsState(),
+            },
+          }),
+          executionEnvironmentStub,
+        );
+
+        const snap = snapController.getExpect(MOCK_SNAP_ID);
+        await snapController.startSnap(snap.id);
+
+        await snapController.handleRequest({
+          snapId: snap.id,
+          origin: MOCK_ORIGIN,
+          handler: HandlerType.OnRpcRequest,
+          request: {
+            jsonrpc: '2.0',
+            method: 'test',
+            params: {},
+            id: 1,
+          },
+        });
+
+        expect(mockTrackEvent).toHaveBeenCalled();
+        expect(log).toHaveBeenCalledWith(
+          expect.stringContaining(
+            'Error when calling MetaMetrics hook for snap',
+          ),
+        );
+        snapController.destroy();
+      });
     });
 
     it('handles a transaction insight request', async () => {

packages/snaps-controllers/src/snaps/SnapController.ts

@@ -3927,7 +3927,15 @@ export class SnapController extends BaseController<
     const snap = this.get(snapId);
 
     if (isTrackableHandler(handlerType) && !snap?.preinstalled) {
-      this.#trackSnapExport(snapId, handlerType, success, origin);
+      try {
+        this.#trackSnapExport(snapId, handlerType, success, origin);
+      } catch (error) {
+        logError(
+          `Error when calling MetaMetrics hook for snap "${snap?.id}": ${getErrorMessage(
+            error,
+          )}`,
+        );
+      }
     }
   }