Fix tests

Author: FrederikBolding

packages/snaps-cli/src/commands/build/implementation.test.ts

@@ -106,9 +106,10 @@ describe('build', () => {
 
     await build(config);
 
-    // Manifest checksum mismatch is the warning
     expect(warn).toHaveBeenCalledWith(
-      expect.stringMatching(/Compiled 1 file in \d+ms with 1 warning\./u),
+      expect.stringMatching(
+        /Compiled \d+ files? in \d+ms with \d+ warnings?\./u,
+      ),
     );
 
     const output = await fs.readFile('/snap/output.js', 'utf8');
@@ -140,9 +141,10 @@ describe('build', () => {
 
     await build(config);
 
-    // Manifest checksum mismatch is the warning
     expect(warn).toHaveBeenCalledWith(
-      expect.stringMatching(/Compiled 1 file in \d+ms with 1 warning\./u),
+      expect.stringMatching(
+        /Compiled \d+ files? in \d+ms with \d+ warnings?\./u,
+      ),
     );
 
     const output = await fs.readFile('/snap/output.js', 'utf8');

packages/snaps-cli/src/commands/watch/watch.e2e.test.ts

@@ -26,13 +26,13 @@ describe('mm-snap watch', () => {
     async (command) => {
       runner = getCommandRunner(command, ['--port', '0']);
       await runner.waitForStderr(
-        /Compiled \d+ files? in \d+ms with 1 warning\./u,
+        /Compiled \d+ files? in \d+ms with \d+ warnings?\./u,
       );
 
       await fs.writeFile(SNAP_FILE, originalFile);
       await runner.waitForStdout(/Changes detected in .+, recompiling\./u);
       await runner.waitForStderr(
-        /Compiled \d+ files? in \d+ms with 1 warning\./u,
+        /Compiled \d+ files? in \d+ms with \d+ warnings?\./u,
       );
 
       expect(runner.stdout).toContainEqual(
@@ -50,7 +50,9 @@ describe('mm-snap watch', () => {
         expect.stringMatching(/Building the Snap bundle\./u),
       );
       expect(runner.stderr).toContainEqual(
-        expect.stringMatching(/Compiled \d+ files? in \d+ms with 1 warning\./u),
+        expect.stringMatching(
+          /Compiled \d+ files? in \d+ms with \d+ warnings?\./u,
+        ),
       );
       expect(runner.stderr).toContainEqual(
         expect.stringContaining(

packages/snaps-utils/coverage.json

@@ -1,6 +1,6 @@
 {
-  "branches": 99.76,
-  "functions": 99.01,
-  "lines": 98.62,
-  "statements": 97.18
+  "branches": 99.53,
+  "functions": 99.02,
+  "lines": 98.52,
+  "statements": 97.12
 }

packages/snaps-utils/src/manifest/manifest.test.ts

@@ -1,4 +1,5 @@
 import { promises as fs } from 'fs';
+import fetchMock from 'jest-fetch-mock';
 import { join } from 'path';
 
 import {
@@ -34,6 +35,17 @@ const BASE_PATH = '/snap';
 const MANIFEST_PATH = join(BASE_PATH, NpmSnapFileNames.Manifest);
 const PACKAGE_JSON_PATH = join(BASE_PATH, NpmSnapFileNames.PackageJson);
 
+const MOCK_GITHUB_RESPONSE = JSON.stringify({
+  // eslint-disable-next-line @typescript-eslint/naming-convention
+  target_commitish: '5fceb7ed2ef18a3984786db1161a76ca5c8e15b9',
+});
+
+const MOCK_PACKAGE_JSON = JSON.stringify({
+  dependencies: {
+    '@metamask/snaps-sdk': getPlatformVersion(),
+  },
+});
+
 /**
  * Get the default manifest for the current platform version.
  *
@@ -73,9 +85,16 @@ async function resetFileSystem() {
 
 describe('checkManifest', () => {
   beforeEach(async () => {
+    fetchMock.enableMocks();
+    fetchMock.mockResponses(MOCK_GITHUB_RESPONSE, MOCK_PACKAGE_JSON);
+
     await resetFileSystem();
   });
 
+  afterAll(() => {
+    fetchMock.disableMocks();
+  });
+
   it('returns the status and warnings after processing', async () => {
     const { updated, reports } = await checkManifest(BASE_PATH);
     expect(reports).toHaveLength(0);

packages/snaps-utils/src/manifest/validators/production-platform-version.ts

@@ -15,7 +15,6 @@ const determineProductionVersion = useFileSystemCache(
   inMilliseconds(7, Duration.Day),
   async () => {
     try {
-      // TODO: Cache this check.
       const latestRelease = await fetch(
         'https://api.github.com/repos/metamask/metamask-extension/releases/latest',
       );