Skip to content

Commit 15f8577

Browse files
committed
Update lint workflow (#3108)
This updates the lint workflow for ESLint 9. It seems easier/faster to run ESLint from the root, so I changed the lint job to only run once, rather than for every package.
1 parent 666ad1e commit 15f8577

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

.github/workflows/build-lint-test.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -168,10 +168,6 @@ jobs:
168168
name: Lint
169169
runs-on: ubuntu-latest
170170
needs: prepare
171-
strategy:
172-
fail-fast: false
173-
matrix:
174-
package-name: ${{ fromJson(needs.prepare.outputs.all-workspace-package-names) }}
175171
steps:
176172
- uses: actions/checkout@v4
177173
- name: Setup Node
@@ -180,7 +176,8 @@ jobs:
180176
node-version-file: '.nvmrc'
181177
cache: yarn
182178
- run: yarn --immutable --immutable-cache
183-
- run: yarn workspace ${{ matrix.package-name }} run lint:ci
179+
- name: Lint
180+
run: yarn lint
184181
- name: Require clean working directory
185182
shell: bash
186183
run: |

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,9 @@
2525
"get-release-tag": "ts-node --swc scripts/get-release-tag.ts",
2626
"postinstall": "simple-git-hooks",
2727
"install-chrome": "./scripts/install-chrome.sh",
28-
"lint": "yarn workspaces foreach --all --parallel run lint:eslint && yarn lint:misc --check && yarn lint:tsconfig && yarn constraints && yarn lint:dependencies",
29-
"lint:ci": "yarn lint:eslint && yarn lint:misc --check && yarn lint:tsconfig && yarn constraints && yarn lint:dependencies",
28+
"lint": "yarn lint:eslint && yarn lint:misc --check && yarn lint:tsconfig && yarn constraints && yarn lint:dependencies",
3029
"lint:dependencies": "yarn workspaces foreach --all --parallel --verbose run lint:dependencies && yarn dedupe --check",
31-
"lint:eslint": "eslint . --cache --ext js,cjs,mjs,jsx,ts,mts,cts,tsx",
30+
"lint:eslint": "eslint . --cache",
3231
"lint:fix": "yarn workspaces foreach --all --parallel run lint:eslint --fix && yarn lint:misc --write && yarn lint:tsconfig && yarn constraints --fix && yarn dedupe",
3332
"lint:misc": "prettier --no-error-on-unmatched-pattern --loglevel warn '**/*.json' '**/*.md' '!**/CHANGELOG.md' '**/*.yml' '**/*.html'",
3433
"lint:tsconfig": "node scripts/verify-tsconfig.mjs",

0 commit comments

Comments
 (0)