Use PERMITTED_CHAINS_ENDOWMENT constant

Author: Mrtenz

packages/snaps-controllers/coverage.json

@@ -1,6 +1,6 @@
 {
-  "branches": 92.96,
+  "branches": 92.97,
   "functions": 96.56,
-  "lines": 98.05,
-  "statements": 97.77
+  "lines": 98.06,
+  "statements": 97.78
 }

packages/snaps-controllers/src/snaps/SnapController.test.tsx

@@ -103,7 +103,10 @@ import {
   waitForStateChange,
 } from '../test-utils';
 import { delay } from '../utils';
-import { LEGACY_ENCRYPTION_KEY_DERIVATION_OPTIONS } from './constants';
+import {
+  LEGACY_ENCRYPTION_KEY_DERIVATION_OPTIONS,
+  PERMITTED_CHAINS_ENDOWMENT,
+} from './constants';
 import { SnapsRegistryStatus } from './registry';
 import type { SnapControllerState } from './SnapController';
 import {
@@ -4922,15 +4925,27 @@ describe('SnapController', () => {
       });
 
       const approvedPermissions = {
-        'endowment:ethereum-provider': {
-          caveats: [],
+        'endowment:page-home': {
+          caveats: null,
+        },
+        'endowment:ethereum-provider': {},
+        [PERMITTED_CHAINS_ENDOWMENT]: {
+          caveats: [
+            {
+              type: 'restrictNetworkSwitching',
+              value: ['0x1'],
+            },
+          ],
         },
-        permittedChains: {},
       };
 
       expect(messenger.call).toHaveBeenCalledWith(
         'PermissionController:grantPermissions',
-        { approvedPermissions, subject: { origin: MOCK_SNAP_ID } },
+        {
+          approvedPermissions,
+          subject: { origin: MOCK_SNAP_ID },
+          requestData: expect.any(Object),
+        },
       );
 
       snapController.destroy();

packages/snaps-controllers/src/snaps/SnapController.ts

@@ -127,10 +127,10 @@ import type {
   TerminateAllSnapsAction,
   TerminateSnapAction,
 } from '../services';
-import type { EncryptionResult } from '../types';
-import {
-  type ExportableKeyEncryptor,
-  type KeyDerivationOptions,
+import type {
+  EncryptionResult,
+  ExportableKeyEncryptor,
+  KeyDerivationOptions,
 } from '../types';
 import {
   fetchSnap,
@@ -142,6 +142,7 @@ import {
 import {
   ALLOWED_PERMISSIONS,
   LEGACY_ENCRYPTION_KEY_DERIVATION_OPTIONS,
+  PERMITTED_CHAINS_ENDOWMENT,
 } from './constants';
 import type { SnapLocation } from './location';
 import { detectSnapLocation } from './location';
@@ -3948,7 +3949,7 @@ export class SnapController extends BaseController<
       // This needs to be assigned to have proper type inference.
       const modifiedPermissions: RequestedPermissions = {
         ...newPermissions,
-        permittedChains: {
+        [PERMITTED_CHAINS_ENDOWMENT]: {
           caveats: [
             {
               type: 'restrictNetworkSwitching',

packages/snaps-controllers/src/snaps/constants.ts

@@ -20,3 +20,5 @@ export const LEGACY_ENCRYPTION_KEY_DERIVATION_OPTIONS = {
     iterations: 10_000,
   },
 };
+
+export const PERMITTED_CHAINS_ENDOWMENT = 'endowment:permitted-chains';