Use different strategy

Author: FrederikBolding

packages/snaps-execution-environments/coverage.json

@@ -1,6 +1,6 @@
 {
-  "branches": 80,
-  "functions": 90.06,
+  "branches": 80.27,
+  "functions": 90.13,
   "lines": 90.77,
   "statements": 90.15
 }

packages/snaps-execution-environments/src/common/endowments/network.test.ts

@@ -180,13 +180,14 @@ describe('Network endowments', () => {
       const RESULT = 'OK';
       fetchMock.mockOnce(async () => Promise.resolve(RESULT));
 
-      const { fetch } = network.factory(factoryOptions);
+      const { fetch, Response } = network.factory(factoryOptions);
       const result = await fetch('foo.com');
 
       expect(result.bodyUsed).toBe(false);
       const clonedResult = result.clone();
       expect(clonedResult).toBeDefined();
       expect(await clonedResult.text()).toBe(RESULT);
+      expect(clonedResult).toBeInstanceOf(Response);
       expect(clonedResult).toBeInstanceOf(ResponseWrapper);
     });
 

packages/snaps-execution-environments/src/common/endowments/network.ts

@@ -7,7 +7,7 @@ import type { EndowmentFactoryOptions } from './commonEndowmentFactory';
  * This class wraps a Response object.
  * That way, a teardown process can stop any processes left.
  */
-export class ResponseWrapper extends Response {
+export class ResponseWrapper {
   readonly #teardownRef: { lastTeardown: number };
 
   #ogResponse: Response;
@@ -22,7 +22,6 @@ export class ResponseWrapper extends Response {
     onStart: () => Promise<void>,
     onFinish: () => Promise<void>,
   ) {
-    super();
     this.#ogResponse = ogResponse;
     this.#teardownRef = teardownRef;
     this.#onStart = onStart;
@@ -146,6 +145,12 @@ export class ResponseWrapper extends Response {
   }
 }
 
+class AlteredResponse extends Response {
+  static [Symbol.hasInstance](instance: any) {
+    return instance instanceof Response || instance instanceof ResponseWrapper;
+  }
+}
+
 /**
  * Create a network endowment, consisting of a `fetch` function.
  * This allows us to provide a teardown function, so that we can cancel
@@ -298,7 +303,7 @@ const createNetwork = ({ notify }: EndowmentFactoryOptions = {}) => {
     // These endowments are not (and should never be) available by default.
     Request: harden(Request),
     Headers: harden(Headers),
-    Response: harden(Response),
+    Response: harden(AlteredResponse),
     teardownFunction,
   };
 };