fix: Remove logic for granting CAIP-25 permissions (#3723)

This logic may not be needed. Pending verification.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Removes automatic granting of `endowment:caip25` and related network
lookups, updates default dynamic permission to `endowment:caip25`, and
adjusts tests accordingly.
> 
> - **Core (`SnapController.ts`)**:
> - Remove logic that auto-added `endowment:caip25` based on
`endowment:ethereum-provider` (and associated network client lookups);
permissions are now granted as requested without modification.
> - Drop `NetworkController:getNetworkClientById` and
`SelectedNetworkController:getNetworkClientIdForDomain` from allowed
actions; remove `hex`/`hexToNumber` usage.
> - Change default `dynamicPermissions` from `eth_accounts` to
`endowment:caip25`.
> - **Tests (`SnapController.test.tsx`)**:
> - Delete tests asserting auto-grant of `endowment:caip25` on
install/update; keep install/update flows without CAIP-25 injection.
> - Update dynamic permissions revocation test to use `endowment:caip25`
instead of `eth_accounts`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
9800313. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: Mrtenz

packages/snaps-controllers/src/snaps/SnapController.test.tsx

@@ -6011,275 +6011,6 @@ describe('SnapController', () => {
       snapController.destroy();
     });
 
-    it('grants the `endowment:caip25` permission to a Snap with `endowment:ethereum-provider`', async () => {
-      const rootMessenger = getControllerMessenger();
-      const messenger = getSnapControllerMessenger(rootMessenger);
-
-      rootMessenger.registerActionHandler(
-        'PermissionController:getPermissions',
-        () => ({}),
-      );
-
-      rootMessenger.registerActionHandler(
-        'SelectedNetworkController:getNetworkClientIdForDomain',
-        () => 'mainnet',
-      );
-
-      rootMessenger.registerActionHandler(
-        'NetworkController:getNetworkClientById',
-        () => ({
-          configuration: {
-            chainId: '0x1',
-          },
-        }),
-      );
-
-      const { manifest } = await getMockSnapFilesWithUpdatedChecksum({
-        manifest: getSnapManifest({
-          initialPermissions: {
-            'endowment:page-home': {},
-            'endowment:ethereum-provider': {},
-          },
-        }),
-      });
-
-      const snapController = getSnapController(
-        getSnapControllerOptions({
-          messenger,
-          detectSnapLocation: loopbackDetect({ manifest }),
-        }),
-      );
-
-      await snapController.installSnaps(MOCK_ORIGIN, {
-        [MOCK_SNAP_ID]: {},
-      });
-
-      const approvedPermissions = {
-        'endowment:page-home': {
-          caveats: null,
-        },
-        'endowment:ethereum-provider': {},
-        'endowment:caip25': {
-          caveats: [
-            {
-              type: 'authorizedScopes',
-              value: {
-                requiredScopes: {},
-                optionalScopes: {
-                  'eip155:1': {
-                    accounts: [],
-                  },
-                },
-                sessionProperties: {},
-                isMultichainOrigin: false,
-              },
-            },
-          ],
-        },
-      };
-
-      expect(messenger.call).toHaveBeenCalledWith(
-        'PermissionController:grantPermissions',
-        {
-          approvedPermissions,
-          subject: { origin: MOCK_SNAP_ID },
-          requestData: expect.any(Object),
-        },
-      );
-
-      snapController.destroy();
-    });
-
-    it('grants the `endowment:caip25` permission when updating a Snap with `endowment:ethereum-provider`', async () => {
-      const newVersion = '1.0.2';
-      const newVersionRange = '>=1.0.1';
-
-      const rootMessenger = getControllerMessenger();
-      const messenger = getSnapControllerMessenger(rootMessenger);
-
-      rootMessenger.registerActionHandler(
-        'SelectedNetworkController:getNetworkClientIdForDomain',
-        () => 'mainnet',
-      );
-
-      rootMessenger.registerActionHandler(
-        'NetworkController:getNetworkClientById',
-        () => ({
-          configuration: {
-            chainId: '0x1',
-          },
-        }),
-      );
-
-      const { manifest: originalManifest } =
-        await getMockSnapFilesWithUpdatedChecksum({
-          manifest: getSnapManifest({
-            initialPermissions: {
-              'endowment:page-home': {},
-            },
-          }),
-        });
-
-      const { manifest: updatedManifest } =
-        await getMockSnapFilesWithUpdatedChecksum({
-          manifest: getSnapManifest({
-            version: newVersion,
-            initialPermissions: {
-              'endowment:page-home': {},
-              'endowment:ethereum-provider': {},
-            },
-          }),
-        });
-
-      const detectLocationMock = jest
-        .fn()
-        .mockImplementationOnce(
-          () =>
-            new LoopbackLocation({
-              manifest: originalManifest,
-            }),
-        )
-        .mockImplementationOnce(
-          () =>
-            new LoopbackLocation({
-              manifest: updatedManifest,
-            }),
-        );
-
-      const controller = getSnapController(
-        getSnapControllerOptions({
-          messenger,
-          detectSnapLocation: detectLocationMock,
-        }),
-      );
-
-      await controller.installSnaps(MOCK_ORIGIN, { [MOCK_SNAP_ID]: {} });
-      await controller.stopSnap(MOCK_SNAP_ID);
-
-      const approvedPermissions = {
-        'endowment:page-home': {
-          caveats: null,
-        },
-      };
-
-      expect(messenger.call).toHaveBeenCalledWith(
-        'PermissionController:grantPermissions',
-        {
-          approvedPermissions,
-          subject: { origin: MOCK_SNAP_ID },
-          requestData: expect.any(Object),
-        },
-      );
-
-      jest.mocked(messenger.call).mockClear();
-
-      const result = await controller.installSnaps(MOCK_ORIGIN, {
-        [MOCK_SNAP_ID]: { version: newVersionRange },
-      });
-
-      const updatedApprovedPermissions = {
-        'endowment:page-home': {
-          caveats: null,
-        },
-        'endowment:ethereum-provider': {},
-        'endowment:caip25': {
-          caveats: [
-            {
-              type: 'authorizedScopes',
-              value: {
-                requiredScopes: {},
-                optionalScopes: {
-                  'eip155:1': {
-                    accounts: [],
-                  },
-                },
-                sessionProperties: {},
-                isMultichainOrigin: false,
-              },
-            },
-          ],
-        },
-      };
-
-      expect(messenger.call).toHaveBeenCalledWith(
-        'PermissionController:grantPermissions',
-        {
-          approvedPermissions: updatedApprovedPermissions,
-          subject: { origin: MOCK_SNAP_ID },
-          requestData: expect.any(Object),
-        },
-      );
-
-      expect(result).toStrictEqual({
-        [MOCK_SNAP_ID]: getTruncatedSnap({
-          version: newVersion,
-          initialPermissions: updatedManifest.result.initialPermissions,
-        }),
-      });
-
-      controller.destroy();
-    });
-
-    it('does not grant the `endowment:caip25` permission if the Snap does not have the `endowment:ethereum-provider` permission', async () => {
-      const rootMessenger = getControllerMessenger();
-      const messenger = getSnapControllerMessenger(rootMessenger);
-
-      rootMessenger.registerActionHandler(
-        'PermissionController:getPermissions',
-        () => ({}),
-      );
-
-      rootMessenger.registerActionHandler(
-        'SelectedNetworkController:getNetworkClientIdForDomain',
-        () => {
-          throw new Error('This should not be called.');
-        },
-      );
-
-      rootMessenger.registerActionHandler(
-        'NetworkController:getNetworkClientById',
-        () => {
-          throw new Error('This should not be called.');
-        },
-      );
-
-      const { manifest } = await getMockSnapFilesWithUpdatedChecksum({
-        manifest: getSnapManifest({
-          initialPermissions: {
-            'endowment:page-home': {},
-          },
-        }),
-      });
-
-      const snapController = getSnapController(
-        getSnapControllerOptions({
-          messenger,
-          detectSnapLocation: loopbackDetect({ manifest }),
-        }),
-      );
-
-      await snapController.installSnaps(MOCK_ORIGIN, {
-        [MOCK_SNAP_ID]: {},
-      });
-
-      const approvedPermissions = {
-        'endowment:page-home': {
-          caveats: null,
-        },
-      };
-
-      expect(messenger.call).toHaveBeenCalledWith(
-        'PermissionController:grantPermissions',
-        {
-          approvedPermissions,
-          subject: { origin: MOCK_SNAP_ID },
-          requestData: expect.any(Object),
-        },
-      );
-
-      snapController.destroy();
-    });
-
     it('supports preinstalled snaps', async () => {
       const rootMessenger = getControllerMessenger();
       jest.spyOn(rootMessenger, 'call');
@@ -11804,12 +11535,12 @@ describe('SnapController', () => {
       const callActionSpy = jest.spyOn(messenger, 'call');
 
       messenger.call('SnapController:revokeDynamicPermissions', MOCK_SNAP_ID, [
-        'eth_accounts',
+        'endowment:caip25',
       ]);
 
       expect(callActionSpy).toHaveBeenCalledWith(
         'PermissionController:revokePermissions',
-        { [MOCK_SNAP_ID]: ['eth_accounts'] },
+        { [MOCK_SNAP_ID]: ['endowment:caip25'] },
       );
 
       snapController.destroy();