chore: Bump supported browsers (#3441)

FrederikBolding · web-flow · commit 4d465296a6d7 · 2025-06-06T10:23:31.000Z
Bump supported browsers to the newest supported browsers in extension `main`: MetaMask/metamask-extension#32529 This lets us simplify NPM fetching since `DecompressionStream` is always available.
diff --git a/packages/examples/packages/interactive-ui/snap.manifest.json b/packages/examples/packages/interactive-ui/snap.manifest.json
@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snaps.git"
   },
   "source": {
-    "shasum": "WzLK3O+UDxp21rn2S7qTcxYhF68lIqkhPY9NvYdvb4I=",
+    "shasum": "O7tN7uyeG6k16/bJCKD3XJv5FBRFE6mnOY2QNy3I9kg=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",
diff --git a/packages/examples/packages/invoke-snap/packages/core-signer/snap.manifest.json b/packages/examples/packages/invoke-snap/packages/core-signer/snap.manifest.json
@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snaps.git"
   },
   "source": {
-    "shasum": "+jFwsG4+F8FBHtCk+8OgcIgFHG+E/mNF3CrRU2pK4YA=",
+    "shasum": "3A0BUTJ+DHvVBjmg4Cjhl4LwPgVJ4GhLfJNAh+5GIM8=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",
diff --git a/packages/examples/packages/localization/snap.manifest.json b/packages/examples/packages/localization/snap.manifest.json
@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snaps.git"
   },
   "source": {
-    "shasum": "5mfvCMuWQkd9phDHEBEJiLyMLfb1KgLKycW5wWQ08z4=",
+    "shasum": "7F+JcFWi/TJ9Y+rvT8Q9XMZXxi0cy1ziKLebWLaP/nI=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",
diff --git a/packages/examples/packages/manage-state/snap.manifest.json b/packages/examples/packages/manage-state/snap.manifest.json
@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snaps.git"
   },
   "source": {
-    "shasum": "kNc/HuLKez0zGeUg3ZSewm5cgBzLG3RPRMS+qL5xTyc=",
+    "shasum": "wWBV5HSMlrszD7u3rT9RWBzpJBounERbjYDSgnqZbqc=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",
diff --git a/packages/examples/packages/network-access/snap.manifest.json b/packages/examples/packages/network-access/snap.manifest.json
@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snaps.git"
   },
   "source": {
-    "shasum": "qR1m6ndfuR+6dI+uNzYOrB5+YNYaMAui336dTDK6lfU=",
+    "shasum": "pI9KeblxJiVTLgrjoxAdKxAssktl6llijsNfQX23ens=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",
diff --git a/packages/examples/packages/preinstalled/snap.manifest.json b/packages/examples/packages/preinstalled/snap.manifest.json
@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snaps.git"
   },
   "source": {
-    "shasum": "9pLJELG6Af9yKL6jm7vMgjn6v2eBwA7iI4XvL0s99vA=",
+    "shasum": "Lo480FuUZvB000pP995rtXSi817KXgCP3BKbeqbmQu4=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",
diff --git a/packages/examples/packages/send-flow/snap.manifest.json b/packages/examples/packages/send-flow/snap.manifest.json
@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snaps.git"
   },
   "source": {
-    "shasum": "foJbsWoBUL/ZEEgqxb6lkiByn0vqEx0Pm3W4s/aM55M=",
+    "shasum": "qjt7VnbamVY2pfxJvWUlteD3h7tRZxCLvugw/t51wlE=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",
diff --git a/packages/examples/packages/transaction-insights/snap.manifest.json b/packages/examples/packages/transaction-insights/snap.manifest.json
@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snaps.git"
   },
   "source": {
-    "shasum": "4xwO2LX4aAE420TxAlmCkW0adkMG9Pmuwpzgd3DBm5A=",
+    "shasum": "g+7MTjHg1wd3HT2HRS75zzG34Pn2cMGeu+K3CVsLQCo=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",
diff --git a/packages/snaps-cli/.browserslistrc b/packages/snaps-cli/.browserslistrc
@@ -1,3 +1,3 @@
 # The minimum browser versions supported by MetaMask.
-chrome >= 90
-firefox >= 91
+chrome >= 113
+firefox >= 115
diff --git a/packages/snaps-cli/src/webpack/utils.test.ts b/packages/snaps-cli/src/webpack/utils.test.ts
@@ -66,8 +66,8 @@ describe('getBrowserslistTargets', () => {
     const targets = await getBrowserslistTargets();
     expect(targets).toMatchInlineSnapshot(`
       [
-        "chrome >= 90",
-        "firefox >= 91",
+        "chrome >= 113",
+        "firefox >= 115",
       ]
     `);
   });
diff --git a/packages/snaps-controllers/coverage.json b/packages/snaps-controllers/coverage.json
@@ -1,5 +1,5 @@
 {
-  "branches": 95.13,
+  "branches": 95.26,
   "functions": 98.42,
   "lines": 98.79,
   "statements": 98.62
diff --git a/packages/snaps-controllers/package.json b/packages/snaps-controllers/package.json
@@ -97,7 +97,6 @@
     "@metamask/utils": "^11.4.0",
     "@xstate/fsm": "^2.0.0",
     "async-mutex": "^0.5.0",
-    "browserify-zlib": "^0.2.0",
     "concat-stream": "^2.0.0",
     "fast-deep-equal": "^3.1.3",
     "get-npm-tarball-url": "^2.0.3",
diff --git a/packages/snaps-controllers/src/snaps/location/npm.test.ts b/packages/snaps-controllers/src/snaps/location/npm.test.ts
@@ -188,74 +188,6 @@ describe('NpmLocation', () => {
     expect(location.version).toBe(templateSnapVersion);
   });
 
-  it('falls back to zlib if DecompressionStream is unavailable', async () => {
-    // @ts-expect-error Deleting DecompressionStream for testing reasons
-    delete globalThis.DecompressionStream;
-
-    const { version: templateSnapVersion } = JSON.parse(
-      (
-        await readFile(require.resolve('@metamask/template-snap/package.json'))
-      ).toString('utf8'),
-    );
-
-    const customFetchMock = jest.fn();
-
-    customFetchMock.mockResolvedValue({
-      ok: true,
-      // eslint-disable-next-line no-restricted-globals
-      headers: new Headers({ 'content-length': '5477' }),
-      body: Readable.toWeb(
-        createReadStream(
-          path.resolve(
-            __dirname,
-            `../../../test/fixtures/metamask-template-snap-${templateSnapVersion}.tgz`,
-          ),
-        ),
-      ),
-    } as any);
-
-    const tarballUrl = `https://registry.npmjs.org/@metamask/template-snap/-/template-snap-${templateSnapVersion}.tgz`;
-
-    const location = new NpmLocation(new URL('npm:@metamask/template-snap'), {
-      versionRange: templateSnapVersion,
-      fetch: customFetchMock as typeof fetch,
-    });
-
-    const manifest = await location.manifest();
-    const sourceCode = (
-      await location.fetch(manifest.result.source.location.npm.filePath)
-    ).toString();
-    assert(manifest.result.source.location.npm.iconPath);
-    const svgIcon = (
-      await location.fetch(manifest.result.source.location.npm.iconPath)
-    ).toString();
-
-    expect(customFetchMock).toHaveBeenCalledTimes(1);
-    expect(customFetchMock).toHaveBeenNthCalledWith(1, tarballUrl);
-
-    expect(manifest.result).toStrictEqual(
-      JSON.parse(
-        (
-          await readFile(
-            require.resolve('@metamask/template-snap/snap.manifest.json'),
-          )
-        ).toString('utf8'),
-      ),
-    );
-
-    expect(sourceCode).toStrictEqual(
-      (
-        await readFile(
-          require.resolve('@metamask/template-snap/dist/bundle.js'),
-        )
-      ).toString('utf8'),
-    );
-
-    expect(svgIcon?.startsWith('<svg') && svgIcon.endsWith('</svg>')).toBe(
-      true,
-    );
-  });
-
   it('throws if fetch fails', async () => {
     fetchMock.mockResponse(async () => ({ status: 404, body: 'Not found' }));
     const location = new NpmLocation(new URL('npm:@metamask/template-snap'));
diff --git a/packages/snaps-controllers/src/snaps/location/npm.ts b/packages/snaps-controllers/src/snaps/location/npm.ts
@@ -17,7 +17,6 @@ import {
   isObject,
   isValidSemVerVersion,
 } from '@metamask/utils';
-import { createGunzip } from 'browserify-zlib';
 import concat from 'concat-stream';
 import getNpmTarballUrl from 'get-npm-tarball-url';
 import { pipeline } from 'readable-stream';
@@ -249,25 +248,11 @@ export class NpmLocation extends BaseNpmLocation {
       // The "gz" in "tgz" stands for "gzip". The tarball needs to be decompressed
       // before we can actually grab any files from it.
       // To prevent recursion-based zip bombs, we should not allow recursion here.
-
-      // If native decompression stream is available we use that, otherwise fallback to zlib.
-      if ('pipeThrough' in body && 'DecompressionStream' in globalThis) {
-        const decompressionStream = new DecompressionStream('gzip');
-        const decompressedStream = body.pipeThrough(decompressionStream);
-
-        pipeline(
-          getNodeStream(decompressedStream),
-          tarballStream,
-          (error: unknown) => {
-            error ? reject(error) : resolve(files);
-          },
-        );
-        return;
-      }
+      const decompressionStream = new DecompressionStream('gzip');
+      const decompressedStream = body.pipeThrough(decompressionStream);
 
       pipeline(
-        getNodeStream(body),
-        createGunzip(),
+        getNodeStream(decompressedStream),
         tarballStream,
         (error: unknown) => {
           error ? reject(error) : resolve(files);
diff --git a/packages/snaps-controllers/src/types/vendor/zlib.d.ts b/packages/snaps-controllers/src/types/vendor/zlib.d.ts
diff --git a/packages/snaps-execution-environments/.browserslistrc b/packages/snaps-execution-environments/.browserslistrc
@@ -1,3 +1,3 @@
 # The minimum browser versions supported by MetaMask.
-chrome >= 90
-firefox >= 91
+chrome >= 113
+firefox >= 115
diff --git a/yarn.lock b/yarn.lock
@@ -4243,7 +4243,6 @@ __metadata:
     "@vitest/browser": "npm:^3.1.1"
     "@xstate/fsm": "npm:^2.0.0"
     async-mutex: "npm:^0.5.0"
-    browserify-zlib: "npm:^0.2.0"
     concat-stream: "npm:^2.0.0"
     deepmerge: "npm:^4.2.2"
     depcheck: "npm:^1.4.7"

Original file line number	Diff line number	Diff line change
`@@ -66,8 +66,8 @@ describe('getBrowserslistTargets', () => {`
`66`	`66`	`const targets = await getBrowserslistTargets();`
`67`	`67`	expect(targets).toMatchInlineSnapshot(`
`68`	`68`	`[`
`69`		`- "chrome >= 90",`
`70`		`- "firefox >= 91",`
	`69`	`+ "chrome >= 113",`
	`70`	`+ "firefox >= 115",`
`71`	`71`	`]`
`72`	`72`	`);
`73`	`73`	`});`