Skip to content

Commit 8aa4a07

Browse files
perf: Use faster registry verification
1 parent e21d3a3 commit 8aa4a07

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

packages/snaps-controllers/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@
9090
"@metamask/phishing-controller": "^15.0.0",
9191
"@metamask/post-message-stream": "^10.0.0",
9292
"@metamask/rpc-errors": "^7.0.3",
93-
"@metamask/snaps-registry": "^3.3.0",
93+
"@metamask/snaps-registry": "^4.0.0",
9494
"@metamask/snaps-rpc-methods": "workspace:^",
9595
"@metamask/snaps-sdk": "workspace:^",
9696
"@metamask/snaps-utils": "workspace:^",

packages/snaps-controllers/src/snaps/registry/json.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ export class JsonSnapsRegistry extends BaseController<
244244
this.#safeFetch(this.#url.signature),
245245
]);
246246

247-
this.#verifySignature(database, signature);
247+
await this.#verifySignature(database, signature);
248248

249249
this.update((state) => {
250250
state.database = JSON.parse(database);
@@ -401,12 +401,11 @@ export class JsonSnapsRegistry extends BaseController<
401401
* @param database - The registry database.
402402
* @param signature - The signature of the registry.
403403
* @throws If the signature is invalid.
404-
* @private
405404
*/
406-
#verifySignature(database: string, signature: string) {
405+
async #verifySignature(database: string, signature: string) {
407406
assert(this.#publicKey, 'No public key provided.');
408407

409-
const valid = verify({
408+
const valid = await verify({
410409
registry: database,
411410
signature: JSON.parse(signature),
412411
publicKey: this.#publicKey,

packages/snaps-utils/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
"@metamask/permission-controller": "^12.1.1",
8686
"@metamask/rpc-errors": "^7.0.3",
8787
"@metamask/slip44": "^4.3.0",
88-
"@metamask/snaps-registry": "^3.3.0",
88+
"@metamask/snaps-registry": "^4.0.0",
8989
"@metamask/snaps-sdk": "workspace:^",
9090
"@metamask/superstruct": "^3.2.1",
9191
"@metamask/utils": "^11.8.1",

0 commit comments

Comments
 (0)