Skip to content

Commit 9459bf6

Browse files
Add note
1 parent 3435d5c commit 9459bf6

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

packages/snaps-controllers/src/snaps/SnapController.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4305,6 +4305,10 @@ export class SnapController extends BaseController<
43054305

43064306
// If the permission doesn't have dependencies, or if at least one of
43074307
// its dependencies is desired, include it in the desired permissions.
4308+
// NOTE: This effectively means that any permissions granted in the manifest
4309+
// that are considered dynamic, will not be automatically revoked
4310+
// when the permission is removed from the manifest.
4311+
// TODO: Deal with this technical debt.
43084312
if (!hasDependencies || hasDependency) {
43094313
accumulator[permissionName] = oldPermissions[permissionName];
43104314
}

0 commit comments

Comments
 (0)