Skip to content

Commit 9ccf7b6

Browse files
committed
Merge branch 'main' into hm/update-notification-example
2 parents 4886c48 + f21e859 commit 9ccf7b6

File tree

11 files changed

+33
-36
lines changed

11 files changed

+33
-36
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ jobs:
9696
re-run:
9797
name: Re-run failed jobs
9898
needs: lint-build-test
99-
if: failure() && fromJSON(github.run_attempt) < 3
99+
if: failure() && fromJSON(github.run_attempt) < 3 && github.event.pull_request.user.login != 'dependabot[bot]'
100100
runs-on: ubuntu-latest
101101
permissions:
102102
actions: write

packages/snaps-controllers/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,9 @@
8585
"@metamask/json-rpc-middleware-stream": "^8.0.5",
8686
"@metamask/key-tree": "^10.0.1",
8787
"@metamask/object-multiplex": "^2.0.0",
88-
"@metamask/permission-controller": "^11.0.3",
88+
"@metamask/permission-controller": "^11.0.4",
8989
"@metamask/phishing-controller": "^12.3.1",
90-
"@metamask/post-message-stream": "^8.1.1",
90+
"@metamask/post-message-stream": "^9.0.0",
9191
"@metamask/rpc-errors": "^7.0.2",
9292
"@metamask/snaps-registry": "^3.2.2",
9393
"@metamask/snaps-rpc-methods": "workspace:^",

packages/snaps-controllers/src/cronjob/CronjobController.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,6 @@ export class CronjobController extends BaseController<
122122
CronjobControllerState,
123123
CronjobControllerMessenger
124124
> {
125-
#messenger: CronjobControllerMessenger;
126-
127125
#dailyTimer!: Timer;
128126

129127
#timers: Map<string, Timer>;
@@ -147,7 +145,6 @@ export class CronjobController extends BaseController<
147145
});
148146
this.#timers = new Map();
149147
this.#snapIds = new Map();
150-
this.#messenger = messenger;
151148

152149
this._handleSnapRegisterEvent = this._handleSnapRegisterEvent.bind(this);
153150
this._handleSnapUnregisterEvent =
@@ -227,7 +224,7 @@ export class CronjobController extends BaseController<
227224
* @returns Array of Cronjob specifications.
228225
*/
229226
#getSnapJobs(snapId: SnapId): Cronjob[] | undefined {
230-
const permissions = this.#messenger.call(
227+
const permissions = this.messagingSystem.call(
231228
'PermissionController:getPermissions',
232229
snapId,
233230
);
@@ -303,7 +300,7 @@ export class CronjobController extends BaseController<
303300
*/
304301
async #executeCronjob(job: Cronjob) {
305302
this.#updateJobLastRunState(job.id, Date.now());
306-
await this.#messenger.call('SnapController:handleRequest', {
303+
await this.messagingSystem.call('SnapController:handleRequest', {
307304
snapId: job.snapId,
308305
origin: '',
309306
handler: HandlerType.OnCronjob,
@@ -387,7 +384,7 @@ export class CronjobController extends BaseController<
387384

388385
const timer = new Timer(ms);
389386
timer.start(() => {
390-
this.#messenger
387+
this.messagingSystem
391388
.call('SnapController:handleRequest', {
392389
snapId: event.snapId,
393390
origin: '',

packages/snaps-execution-environments/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
"dependencies": {
6767
"@metamask/json-rpc-engine": "^10.0.1",
6868
"@metamask/object-multiplex": "^2.0.0",
69-
"@metamask/post-message-stream": "^8.1.1",
69+
"@metamask/post-message-stream": "^9.0.0",
7070
"@metamask/providers": "^18.1.1",
7171
"@metamask/rpc-errors": "^7.0.2",
7272
"@metamask/snaps-sdk": "workspace:^",

packages/snaps-rpc-methods/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
},
5757
"dependencies": {
5858
"@metamask/key-tree": "^10.0.1",
59-
"@metamask/permission-controller": "^11.0.3",
59+
"@metamask/permission-controller": "^11.0.4",
6060
"@metamask/rpc-errors": "^7.0.2",
6161
"@metamask/snaps-sdk": "workspace:^",
6262
"@metamask/snaps-utils": "workspace:^",

packages/snaps-sdk/src/types/permissions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export type RequestedSnap = {
3737

3838
export type InitialPermissions = Partial<{
3939
'endowment:cronjob': {
40-
jobs: Cronjob[];
40+
jobs?: Cronjob[];
4141
maxRequestTime?: number;
4242
};
4343
'endowment:ethereum-provider': EmptyObject;

packages/snaps-simulation/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
"@metamask/json-rpc-engine": "^10.0.1",
6161
"@metamask/json-rpc-middleware-stream": "^8.0.5",
6262
"@metamask/key-tree": "^10.0.1",
63-
"@metamask/permission-controller": "^11.0.3",
63+
"@metamask/permission-controller": "^11.0.4",
6464
"@metamask/phishing-controller": "^12.3.1",
6565
"@metamask/snaps-controllers": "workspace:^",
6666
"@metamask/snaps-execution-environments": "workspace:^",

packages/snaps-simulator/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"@metamask/json-rpc-engine": "^10.0.1",
5252
"@metamask/json-rpc-middleware-stream": "^8.0.5",
5353
"@metamask/key-tree": "^10.0.1",
54-
"@metamask/permission-controller": "^11.0.3",
54+
"@metamask/permission-controller": "^11.0.4",
5555
"@metamask/snaps-controllers": "workspace:^",
5656
"@metamask/snaps-execution-environments": "workspace:^",
5757
"@metamask/snaps-rpc-methods": "workspace:^",

packages/snaps-utils/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
"@babel/types": "^7.23.0",
8282
"@metamask/base-controller": "^7.0.2",
8383
"@metamask/key-tree": "^10.0.1",
84-
"@metamask/permission-controller": "^11.0.3",
84+
"@metamask/permission-controller": "^11.0.4",
8585
"@metamask/rpc-errors": "^7.0.2",
8686
"@metamask/slip44": "^4.1.0",
8787
"@metamask/snaps-registry": "^3.2.2",
@@ -110,7 +110,7 @@
110110
"@metamask/eslint-config-jest": "^12.1.0",
111111
"@metamask/eslint-config-nodejs": "^12.1.0",
112112
"@metamask/eslint-config-typescript": "^12.1.0",
113-
"@metamask/post-message-stream": "^8.1.1",
113+
"@metamask/post-message-stream": "^9.0.0",
114114
"@swc/core": "1.3.78",
115115
"@swc/jest": "^0.2.26",
116116
"@ts-bridge/cli": "^0.6.1",

packages/snaps-utils/src/manifest/validation.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ export const PermissionsStruct: Describe<InitialPermissions> = type({
191191
'endowment:cronjob': optional(
192192
mergeStructs(
193193
HandlerCaveatsStruct,
194-
object({ jobs: CronjobSpecificationArrayStruct }),
194+
object({ jobs: optional(CronjobSpecificationArrayStruct) }),
195195
),
196196
),
197197
'endowment:ethereum-provider': optional(EmptyObjectStruct),

0 commit comments

Comments
 (0)