Add tests and fix type issue

Author: GuillaumeRx

packages/snaps-controllers/coverage.json

@@ -1,5 +1,5 @@
 {
-  "branches": 93.36,
+  "branches": 93.37,
   "functions": 97.38,
   "lines": 98.34,
   "statements": 98.07

packages/snaps-controllers/src/snaps/SnapController.test.tsx

@@ -4354,6 +4354,145 @@ describe('SnapController', () => {
     });
   });
 
+  describe('onAssetHistoricalPrice', () => {
+    it('throws if `onAssetHistoricalPrice` handler returns an invalid response', async () => {
+      const rootMessenger = getControllerMessenger();
+      const messenger = getSnapControllerMessenger(rootMessenger);
+      const snapController = getSnapController(
+        getSnapControllerOptions({
+          messenger,
+          state: {
+            snaps: getPersistedSnapsState(),
+          },
+        }),
+      );
+
+      rootMessenger.registerActionHandler(
+        'PermissionController:getPermissions',
+        () => ({
+          [SnapEndowments.Assets]: {
+            caveats: [
+              {
+                type: SnapCaveatType.ChainIds,
+                value: ['bip122:000000000019d6689c085ae165831e93'],
+              },
+            ],
+            date: 1664187844588,
+            id: 'izn0WGUO8cvq_jqvLQuQP',
+            invoker: MOCK_SNAP_ID,
+            parentCapability: SnapEndowments.Assets,
+          },
+        }),
+      );
+
+      rootMessenger.registerActionHandler(
+        'SubjectMetadataController:getSubjectMetadata',
+        () => MOCK_SNAP_SUBJECT_METADATA,
+      );
+
+      rootMessenger.registerActionHandler(
+        'ExecutionService:handleRpcRequest',
+        async () =>
+          Promise.resolve({
+            historicalPrice: { foo: {} },
+          }),
+      );
+
+      await expect(
+        snapController.handleRequest({
+          snapId: MOCK_SNAP_ID,
+          origin: 'foo.com',
+          handler: HandlerType.OnAssetHistoricalPrice,
+          request: {
+            jsonrpc: '2.0',
+            method: ' ',
+            params: {},
+            id: 1,
+          },
+        }),
+      ).rejects.toThrow(
+        `Assertion failed: At path: historicalPrice.intervals -- Expected an object, but received: undefined.`,
+      );
+
+      snapController.destroy();
+    });
+
+    it('returns the value when `onAssetHistoricalPrice` returns a valid response', async () => {
+      const rootMessenger = getControllerMessenger();
+      const messenger = getSnapControllerMessenger(rootMessenger);
+      const snapController = getSnapController(
+        getSnapControllerOptions({
+          messenger,
+          state: {
+            snaps: getPersistedSnapsState(),
+          },
+        }),
+      );
+
+      rootMessenger.registerActionHandler(
+        'PermissionController:getPermissions',
+        () => ({
+          [SnapEndowments.Assets]: {
+            caveats: [
+              {
+                type: SnapCaveatType.ChainIds,
+                value: ['bip122:000000000019d6689c085ae165831e93'],
+              },
+            ],
+            date: 1664187844588,
+            id: 'izn0WGUO8cvq_jqvLQuQP',
+            invoker: MOCK_SNAP_ID,
+            parentCapability: SnapEndowments.Assets,
+          },
+        }),
+      );
+
+      rootMessenger.registerActionHandler(
+        'SubjectMetadataController:getSubjectMetadata',
+        () => MOCK_SNAP_SUBJECT_METADATA,
+      );
+
+      rootMessenger.registerActionHandler(
+        'ExecutionService:handleRpcRequest',
+        async () =>
+          Promise.resolve({
+            historicalPrice: {
+              intervals: {
+                P1D: [[1737548790, '400']],
+              },
+              updateTime: 1737548790,
+            },
+          }),
+      );
+
+      expect(
+        await snapController.handleRequest({
+          snapId: MOCK_SNAP_ID,
+          origin: 'foo.com',
+          handler: HandlerType.OnAssetHistoricalPrice,
+          request: {
+            jsonrpc: '2.0',
+            method: ' ',
+            params: {
+              from: 'bip122:000000000019d6689c085ae165831e93/slip44:0',
+              to: 'swift:0/iso4217:USD',
+            },
+            id: 1,
+          },
+        }),
+      ).toStrictEqual({
+        historicalPrice: {
+          intervals: {
+            P1D: [[1737548790, '400']],
+          },
+          updateTime: 1737548790,
+        },
+      });
+
+      snapController.destroy();
+    });
+  });
+
   describe('getRpcRequestHandler', () => {
     it('handlers populate the "jsonrpc" property if missing', async () => {
       const rootMessenger = getControllerMessenger();

packages/snaps-execution-environments/coverage.json

@@ -1,6 +1,6 @@
 {
-  "branches": 80,
+  "branches": 80.66,
   "functions": 89.1,
-  "lines": 90.64,
-  "statements": 89.59
+  "lines": 90.78,
+  "statements": 89.72
 }

packages/snaps-sdk/src/types/handlers/asset-historical-price.ts

@@ -19,13 +19,13 @@ export type HistoricalPriceIntervals = {
  *
  * @property historicalPrice - The historical price object
  * @property historicalPrice.intervals - The historical price of the asset pair.
- * @property historicalPrice.conversionTime - The time at which the conversion rate was calculated.
- * @property historicalPrice.expirationTime - The time at which the conversion rate expires.
+ * @property historicalPrice.updateTime - The time at which the historical price has been calculated.
+ * @property historicalPrice.expirationTime - The time at which the historical price expires.
  */
 export type OnAssetHistoricalPriceResponse = {
   historicalPrice: {
     intervals: HistoricalPriceIntervals;
-    conversionTime: number;
+    updateTime: number;
     expirationTime?: number;
   };
 } | null;