Fix SnapInsightsController tests

Author: Mrtenz

packages/snaps-controllers/src/insights/SnapInsightsController.test.ts

@@ -85,8 +85,8 @@ describe('SnapInsightsController', () => {
       },
     });
 
-    expect(rootMessenger.call).toHaveBeenCalledTimes(5);
-    expect(rootMessenger.call).toHaveBeenNthCalledWith(
+    expect(controllerMessenger.call).toHaveBeenCalledTimes(5);
+    expect(controllerMessenger.call).toHaveBeenNthCalledWith(
       4,
       'SnapController:handleRequest',
       {
@@ -103,7 +103,7 @@ describe('SnapInsightsController', () => {
         },
       },
     );
-    expect(rootMessenger.call).toHaveBeenNthCalledWith(
+    expect(controllerMessenger.call).toHaveBeenNthCalledWith(
       5,
       'SnapController:handleRequest',
       {
@@ -132,8 +132,8 @@ describe('SnapInsightsController', () => {
     });
 
     expect(Object.values(controller.state.insights)).toHaveLength(0);
-    expect(rootMessenger.call).toHaveBeenCalledTimes(6);
-    expect(rootMessenger.call).toHaveBeenNthCalledWith(
+    expect(controllerMessenger.call).toHaveBeenCalledTimes(6);
+    expect(controllerMessenger.call).toHaveBeenNthCalledWith(
       6,
       'SnapInterfaceController:deleteInterface',
       expect.any(String),
@@ -210,8 +210,8 @@ describe('SnapInsightsController', () => {
       },
     });
 
-    expect(rootMessenger.call).toHaveBeenCalledTimes(5);
-    expect(rootMessenger.call).toHaveBeenNthCalledWith(
+    expect(controllerMessenger.call).toHaveBeenCalledTimes(5);
+    expect(controllerMessenger.call).toHaveBeenNthCalledWith(
       4,
       'SnapController:handleRequest',
       {
@@ -232,7 +232,7 @@ describe('SnapInsightsController', () => {
         },
       },
     );
-    expect(rootMessenger.call).toHaveBeenNthCalledWith(
+    expect(controllerMessenger.call).toHaveBeenNthCalledWith(
       5,
       'SnapController:handleRequest',
       {
@@ -267,8 +267,8 @@ describe('SnapInsightsController', () => {
     );
 
     expect(Object.values(controller.state.insights)).toHaveLength(0);
-    expect(rootMessenger.call).toHaveBeenCalledTimes(6);
-    expect(rootMessenger.call).toHaveBeenNthCalledWith(
+    expect(controllerMessenger.call).toHaveBeenCalledTimes(6);
+    expect(controllerMessenger.call).toHaveBeenNthCalledWith(
       6,
       'SnapInterfaceController:deleteInterface',
       expect.any(String),
@@ -335,8 +335,8 @@ describe('SnapInsightsController', () => {
       },
     });
 
-    expect(rootMessenger.call).toHaveBeenCalledTimes(5);
-    expect(rootMessenger.call).toHaveBeenNthCalledWith(
+    expect(controllerMessenger.call).toHaveBeenCalledTimes(5);
+    expect(controllerMessenger.call).toHaveBeenNthCalledWith(
       4,
       'SnapController:handleRequest',
       {
@@ -356,7 +356,7 @@ describe('SnapInsightsController', () => {
         },
       },
     );
-    expect(rootMessenger.call).toHaveBeenNthCalledWith(
+    expect(controllerMessenger.call).toHaveBeenNthCalledWith(
       5,
       'SnapController:handleRequest',
       {
@@ -449,7 +449,7 @@ describe('SnapInsightsController', () => {
       },
     });
 
-    expect(rootMessenger.call).toHaveBeenCalledTimes(8);
+    expect(controllerMessenger.call).toHaveBeenCalledTimes(8);
   });
 
   it('ignores insight if transaction has already been signed', async () => {
@@ -509,8 +509,8 @@ describe('SnapInsightsController', () => {
 
     expect(Object.values(controller.state.insights)).toHaveLength(0);
 
-    expect(rootMessenger.call).toHaveBeenCalledTimes(5);
-    expect(rootMessenger.call).toHaveBeenNthCalledWith(
+    expect(controllerMessenger.call).toHaveBeenCalledTimes(5);
+    expect(controllerMessenger.call).toHaveBeenNthCalledWith(
       4,
       'SnapController:handleRequest',
       {
@@ -527,7 +527,7 @@ describe('SnapInsightsController', () => {
         },
       },
     );
-    expect(rootMessenger.call).toHaveBeenNthCalledWith(
+    expect(controllerMessenger.call).toHaveBeenNthCalledWith(
       5,
       'SnapController:handleRequest',
       {
@@ -607,8 +607,8 @@ describe('SnapInsightsController', () => {
 
     expect(Object.values(controller.state.insights)).toHaveLength(0);
 
-    expect(rootMessenger.call).toHaveBeenCalledTimes(5);
-    expect(rootMessenger.call).toHaveBeenNthCalledWith(
+    expect(controllerMessenger.call).toHaveBeenCalledTimes(5);
+    expect(controllerMessenger.call).toHaveBeenNthCalledWith(
       4,
       'SnapController:handleRequest',
       {
@@ -628,7 +628,7 @@ describe('SnapInsightsController', () => {
         },
       },
     );
-    expect(rootMessenger.call).toHaveBeenNthCalledWith(
+    expect(controllerMessenger.call).toHaveBeenNthCalledWith(
       5,
       'SnapController:handleRequest',
       {

packages/snaps-controllers/src/test-utils/controller.tsx

@@ -879,6 +879,8 @@ export const getRestrictedSnapInsightsControllerMessenger = (
     messenger: controllerMessenger,
   });
 
+  jest.spyOn(controllerMessenger, 'call');
+
   return controllerMessenger;
 };