fix: Destroying execution environment streams should emit events

FrederikBolding · FrederikBolding · commit e850acc4c1c6 · 2025-02-06T12:20:52.000+01:00
diff --git a/packages/snaps-controllers/src/services/AbstractExecutionService.ts b/packages/snaps-controllers/src/services/AbstractExecutionService.ts
@@ -188,8 +188,7 @@ export abstract class AbstractExecutionService<WorkerType>
 
     Object.values(jobWrapper.streams).forEach((stream) => {
       try {
-        !stream.destroyed && stream.destroy();
-        stream.removeAllListeners();
+        stream.destroy();
       } catch (error) {
         logError('Error while destroying stream', error);
       }

Original file line number	Diff line number	Diff line change
`@@ -188,8 +188,7 @@ export abstract class AbstractExecutionService<WorkerType>`
`188`	`188`
`189`	`189`	`Object.values(jobWrapper.streams).forEach((stream) => {`
`190`	`190`	`try {`
`191`		`- !stream.destroyed && stream.destroy();`
`192`		`- stream.removeAllListeners();`
	`191`	`+ stream.destroy();`
`193`	`192`	`} catch (error) {`
`194`	`193`	`logError('Error while destroying stream', error);`
`195`	`194`	`}`