address comments

Author: GuillaumeRx

packages/examples/packages/browserify-plugin/snap.manifest.json

@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snaps.git"
   },
   "source": {
-    "shasum": "DYLBW3jdovQYu6jwACo/3xlujGXb0YxJ19UEpUKX1qE=",
+    "shasum": "jhSaoXggl7hhgHzX7tkJvz5Ig7tLJFl6RLLD81e1628=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",

packages/examples/packages/browserify/snap.manifest.json

@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snaps.git"
   },
   "source": {
-    "shasum": "dFTqb94KtIZ44IaoMYhGunl9c9Of9j67TNYobl+CwYg=",
+    "shasum": "qlJe2g0xM6TBU8vzDMmybMmcKXq20PU0ZEhQwKcajoo=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",

packages/examples/packages/settings-page/CHANGELOG.md

@@ -7,41 +7,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-## [1.1.3]
-
-### Fixed
-
-- Bump MetaMask dependencies
-
-## [1.1.2]
-
-### Changed
-
-- Use error wrappers ([#2178](https://github.com/MetaMask/snaps/pull/2178))
-
-## [1.1.1]
-
-### Changed
-
-- Remove snap icon ([#2189](https://github.com/MetaMask/snaps/pull/2189))
-
-## [1.1.0]
-
-### Changed
-
-- Use `@metamask/snaps-sdk` package ([#1946](https://github.com/MetaMask/snaps/pull/1946), [#1954](https://github.com/MetaMask/snaps/pull/1954))
-  - This package replaces the `@metamask/snaps-types` and
-  - `@metamask/snaps-ui` packages, and is much more lightweight.
-
-## [1.0.0]
-
-### Added
-
-- Initial release ([#1918](https://github.com/MetaMask/snaps/pull/1918))
-
-[Unreleased]: https://github.com/MetaMask/snaps/compare/@metamask/[email protected]
-[1.1.3]: https://github.com/MetaMask/snaps/compare/@metamask/[email protected]...@metamask/[email protected]
-[1.1.2]: https://github.com/MetaMask/snaps/compare/@metamask/[email protected]...@metamask/[email protected]
-[1.1.1]: https://github.com/MetaMask/snaps/compare/@metamask/[email protected]...@metamask/[email protected]
-[1.1.0]: https://github.com/MetaMask/snaps/compare/@metamask/[email protected]...@metamask/[email protected]
-[1.0.0]: https://github.com/MetaMask/snaps/releases/tag/@metamask/[email protected]
+[Unreleased]: https://github.com/MetaMask/snaps/

packages/examples/packages/settings-page/README.md

@@ -3,6 +3,8 @@
 This snap demonstrates how to use `endowment:page-settings` permission to show
 a settings page that leverages custom UI components.
 
+This endowment is initially restricted to preinstalled snaps only.
+
 ## Snap manifest
 
 The manifest of this snap includes the `endowment:page-settings` permission:

packages/examples/packages/settings-page/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@metamask/settings-page-example-snap",
-  "version": "1.1.3",
+  "version": "0.0.0",
   "description": "MetaMask example snap demonstrating the use of settings pages",
   "keywords": [
     "MetaMask",
@@ -25,8 +25,8 @@
   "scripts": {
     "build": "mm-snap build",
     "build:clean": "yarn clean && yarn build",
-    "changelog:update": "../../../../scripts/update-changelog.sh @metamask/home-page-example-snap",
-    "changelog:validate": "../../../../scripts/validate-changelog.sh @metamask/home-page-example-snap",
+    "changelog:update": "../../../../scripts/update-changelog.sh @metamask/settings-page-example-snap",
+    "changelog:validate": "../../../../scripts/validate-changelog.sh @metamask/settings-page-example-snap",
     "clean": "rimraf \"dist\"",
     "lint": "yarn lint:eslint && yarn lint:misc --check && yarn changelog:validate && yarn lint:dependencies",
     "lint:ci": "yarn lint",

packages/examples/packages/settings-page/snap.manifest.json

@@ -1,13 +1,13 @@
 {
-  "version": "1.1.3",
+  "version": "0.0.0",
   "description": "MetaMask example snap demonstrating the use of settings pages.",
   "proposedName": "Settings Page Example Snap",
   "repository": {
     "type": "git",
     "url": "https://github.com/MetaMask/snaps.git"
   },
   "source": {
-    "shasum": "1EtjSOu6ZrLaiCRMQo03YWHnXKsjDV0bIyS0mhiImpw=",
+    "shasum": "yWcDv7XuV/FGRxKdOMkelR4qB0Ivel7oP9fEuNz0EE8=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",

packages/snaps-execution-environments/coverage.json

@@ -1,6 +1,6 @@
 {
   "branches": 80.68,
   "functions": 89.26,
-  "lines": 90.67,
-  "statements": 90.06
+  "lines": 90.66,
+  "statements": 90.05
 }

packages/snaps-utils/coverage.json

@@ -2,5 +2,5 @@
   "branches": 99.74,
   "functions": 98.93,
   "lines": 99.46,
-  "statements": 96.18
+  "statements": 96.25
 }

packages/snaps-utils/src/handlers.ts

@@ -140,22 +140,20 @@ export const OnTransactionResponseStruct = nullable(
 
 export const OnSignatureResponseStruct = OnTransactionResponseStruct;
 
-export const OnPageResponseWithContentStruct = object({
+export const OnHomePageResponseWithContentStruct = object({
   content: ComponentOrElementStruct,
 });
 
-export const OnPageResponseWithIdStruct = object({
+export const OnHomePageResponseWithIdStruct = object({
   id: string(),
 });
 
-export const OnPageResponseStruct = union([
-  OnPageResponseWithContentStruct,
-  OnPageResponseWithIdStruct,
+export const OnHomePageResponseStruct = union([
+  OnHomePageResponseWithContentStruct,
+  OnHomePageResponseWithIdStruct,
 ]);
 
-export const OnHomePageResponseStruct = OnPageResponseStruct;
-
-export const OnSettingsPageResponseStruct = OnPageResponseStruct;
+export const OnSettingsPageResponseStruct = OnHomePageResponseStruct;
 
 export const AddressResolutionStruct = object({
   protocol: string(),

packages/test-snaps/package.json

@@ -66,6 +66,7 @@
     "@metamask/notification-example-snap": "workspace:^",
     "@metamask/preinstalled-example-snap": "workspace:^",
     "@metamask/send-flow-example-snap": "workspace:^",
+    "@metamask/settings-page-example-snap": "workspace:^",
     "@metamask/signature-insights-example-snap": "workspace:^",
     "@metamask/snaps-utils": "workspace:^",
     "@metamask/utils": "^10.0.0",