Skip to content

Commit ffa7865

Browse files
fix(controllers): Properly pass down execution service constructor args
1 parent 3556c3c commit ffa7865

File tree

6 files changed

+12
-1
lines changed

6 files changed

+12
-1
lines changed

packages/snaps-controllers/src/services/AbstractExecutionService.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,9 @@ import type { ExecutionServiceArgs } from './AbstractExecutionService';
88
import { NodeThreadExecutionService } from './node';
99

1010
class MockExecutionService extends NodeThreadExecutionService {
11-
constructor({ messenger, setupSnapProvider }: ExecutionServiceArgs) {
11+
constructor({ messenger, setupSnapProvider, ...args }: ExecutionServiceArgs) {
1212
super({
13+
...args,
1314
messenger,
1415
setupSnapProvider,
1516
initTimeout: inMilliseconds(5, Duration.Second),

packages/snaps-controllers/src/services/iframe/IframeExecutionService.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,10 @@ export class IframeExecutionService extends AbstractExecutionService<Window> {
1919
iframeUrl,
2020
messenger,
2121
setupSnapProvider,
22+
...args
2223
}: IframeExecutionEnvironmentServiceArgs) {
2324
super({
25+
...args,
2426
messenger,
2527
setupSnapProvider,
2628
});

packages/snaps-controllers/src/services/offscreen/OffscreenExecutionService.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,10 @@ export class OffscreenExecutionService extends ProxyExecutionService {
2525
messenger,
2626
setupSnapProvider,
2727
offscreenPromise,
28+
...args
2829
}: OffscreenExecutionEnvironmentServiceArgs) {
2930
super({
31+
...args,
3032
messenger,
3133
setupSnapProvider,
3234
stream: new BrowserRuntimePostMessageStream({

packages/snaps-controllers/src/services/proxy/ProxyExecutionService.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,10 @@ export class ProxyExecutionService extends AbstractExecutionService<string> {
3030
stream,
3131
messenger,
3232
setupSnapProvider,
33+
...args
3334
}: ProxyExecutionEnvironmentServiceArgs) {
3435
super({
36+
...args,
3537
messenger,
3638
setupSnapProvider,
3739
usePing: false,

packages/snaps-controllers/src/services/webview/WebViewExecutionService.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,10 @@ export class WebViewExecutionService extends ProxyExecutionService {
1414
messenger,
1515
setupSnapProvider,
1616
getWebView,
17+
...args
1718
}: WebViewExecutionServiceArgs) {
1819
super({
20+
...args,
1921
messenger,
2022
setupSnapProvider,
2123
stream: new WebViewMessageStream({

packages/snaps-controllers/src/services/webworker/WebWorkerExecutionService.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,10 @@ export class WebWorkerExecutionService extends AbstractExecutionService<string>
3737
documentUrl,
3838
messenger,
3939
setupSnapProvider,
40+
...args
4041
}: WebWorkerExecutionEnvironmentServiceArgs) {
4142
super({
43+
...args,
4244
messenger,
4345
setupSnapProvider,
4446
});

0 commit comments

Comments
 (0)