-
Notifications
You must be signed in to change notification settings - Fork 639
feat: Implement MultichainRouter and onProtocolRequest (SIP-26)
#2875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5321c38 to
cc4715d
Compare
MultichainRoutingController and onProtocolRequest (SIP-26)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2875 +/- ##
==========================================
+ Coverage 94.80% 94.87% +0.06%
==========================================
Files 503 506 +3
Lines 11001 11123 +122
Branches 1685 1703 +18
==========================================
+ Hits 10430 10553 +123
+ Misses 571 570 -1 ☔ View full report in Codecov by Sentry. |
9817cfc to
8b6e698
Compare
MultichainRoutingController and onProtocolRequest (SIP-26)MultichainRouter and onProtocolRequest (SIP-26)
047e488 to
ba2412d
Compare
0c62acf to
5e42ee7
Compare
5e42ee7 to
50efb61
Compare
2800825 to
9c252ea
Compare
Mrtenz
requested changes
Jan 29, 2025
Mrtenz
previously approved these changes
Jan 29, 2025
Co-authored-by: Maarten Zuidhoorn <[email protected]>
ef7e20c to
2425dcd
Compare
ccharly
reviewed
Jan 31, 2025
danroc
reviewed
Jan 31, 2025
Mrtenz
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
MultichainRouterthat can handle routing of non-EVM requests received via the multichain API. The multichain API should integrate this by callingMultichainRouter.handleRequestfor any requests that are not understood by our existing JSON-RPC stack.Additionally this PR implements
onProtocolRequest, a new handler that Snaps can choose to register if they want to service protocol (non signing) requests for a given set of methods for one or more chains. The endowment is registered as follows:This implementation follows https://metamask.github.io/SIPs/SIPS/sip-26
Closes #2898