fix: Add isSecureContext endowment
#2893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2893 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 486 486
Lines 10399 10399
Branches 1594 1594
=======================================
Hits 9825 9825
Misses 574 574 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Mrtenz
approved these changes
Nov 19, 2024
naugtur
approved these changes
Nov 19, 2024
naugtur
left a comment
naugtur
left a comment
There was a problem hiding this comment.
this is fine. I'm also wondering if passing true wouldn't be enough
FrederikBolding
force-pushed
the
fb/add-is-secure-context-endowment
branch
from
87dd64b to
2fa278d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
isSecureContextfor the browser environments, this will continue to be undefined in the Node.js environment.Fixes #2890