Add property and hook for specifying custom cryptography functions #2909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2909 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 487 487
Lines 10427 10429 +2
Branches 1598 1598
=======================================
+ Hits 9852 9854 +2
Misses 575 575 ☔ View full report in Codecov by Sentry. |
FrederikBolding
previously approved these changes
Nov 28, 2024
Mrtenz
changed the title
getClientCryptography hook to SnapController and related JSON-RPC methods
FrederikBolding
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
key-treenow allows specifying custom functions to use for cryptography. To support this in Snaps, I've added a new hookgetClientCryptographyto theSnapControllerand entropy-related JSON-RPC methods. This hook should return an object containing the functions to use (or just an empty object to use the defaults).