fix: Improve field validation errors #2937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/improve-field-validation
branch
from
159f448 to
43570a4
Compare
Mrtenz
reviewed
Dec 10, 2024
Co-authored-by: Maarten Zuidhoorn <[email protected]>
Mrtenz
previously approved these changes
Dec 10, 2024
Mrtenz
approved these changes
Dec 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2937 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 487 487
Lines 10442 10450 +8
Branches 1600 1604 +4
=======================================
+ Hits 9867 9875 +8
Misses 575 575 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves validation errors for
Fieldby rewriting the struct usingselectiveUnion.Fixes #2927