fix: Skip unnecesary provider initialization #2967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
commented
Dec 19, 2024
| }); | ||
|
|
||
| await provider.initialize(); | ||
| provider.initializeSync(); |
Member
Author
There was a problem hiding this comment.
This is the main change of this PR alongside the introduction of the SnapProvider wrapper class
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2967 +/- ##
=======================================
Coverage 94.59% 94.59%
=======================================
Files 493 494 +1
Lines 10654 10656 +2
Branches 1635 1635
=======================================
+ Hits 10078 10080 +2
Misses 576 576 ☔ View full report in Codecov by Sentry. |
Mrtenz
approved these changes
Dec 19, 2024
PatrykLucka
pushed a commit
that referenced
this pull request
Jan 13, 2025
Since we only expose the `request` function from the provider and don't allow listening to events or using `provider.chainId` etc we can initialize the provider without making the `metamask_getProviderState` request. This saves us a potential network request that may add overhead to booting the Snap. Specifically the clients call `net_version` since this property is required in the `MetaMaskInpageProvider`. Closes #2968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we only expose the
requestfunction from the provider and don't allow listening to events or usingprovider.chainIdetc we can initialize the provider without making themetamask_getProviderStaterequest. This saves us a potential network request that may add overhead to booting the Snap. Specifically the clients callnet_versionsince this property is required in theMetaMaskInpageProvider.Closes #2968