feat: Add hideBalances to snap_getPreferences
#2978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2978 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 497 497
Lines 10802 10802
Branches 1649 1649
=======================================
Hits 10231 10231
Misses 571 571 ☔ View full report in Codecov by Sentry. |
Mrtenz
requested changes
Jan 7, 2025
Mrtenz
approved these changes
Jan 7, 2025
FrederikBolding
approved these changes
Jan 7, 2025
Mrtenz
pushed a commit
that referenced
this pull request
Jan 8, 2025
This adds a new property to the `snap_getPreferences` return value called `hideBalances` which binds to the property existing in the preference controller called `privacyMode`. Fixes: #2977
PatrykLucka
pushed a commit
that referenced
this pull request
Jan 13, 2025
This adds a new property to the `snap_getPreferences` return value called `hideBalances` which binds to the property existing in the preference controller called `privacyMode`. Fixes: #2977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new property to the
snap_getPreferencesreturn value calledhideBalanceswhich binds to the property existing in the preference controller calledprivacyMode.Fixes: #2977