Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jan 23, 2025

Add Intl as a default endowment to allow Snaps to use the browser native functionality for formatting text and numbers in the UI.

Closes #3034

@FrederikBolding FrederikBolding marked this pull request as ready for review January 23, 2025 12:01
@FrederikBolding FrederikBolding requested a review from a team as a code owner January 23, 2025 12:01
@codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (78dd810) to head (261ce6f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3035   +/-   ##
=======================================
  Coverage   94.80%   94.80%           
=======================================
  Files         503      503           
  Lines       10996    10996           
  Branches     1685     1685           
=======================================
  Hits        10425    10425           
  Misses        571      571           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 677b049 into main Jan 23, 2025
166 checks passed
@FrederikBolding FrederikBolding deleted the fb/add-intl branch January 23, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate exposing Intl to Snaps

4 participants