Add name and state to ExecutionService and MultichainRouter
#3058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3058 +/- ##
=======================================
Coverage 94.88% 94.88%
=======================================
Files 506 506
Lines 11120 11124 +4
Branches 1703 1703
=======================================
+ Hits 10551 10555 +4
Misses 569 569 ☔ View full report in Codecov by Sentry. |
FrederikBolding
previously approved these changes
Feb 4, 2025
Mrtenz
changed the title
name and state to ExecutionService typename and state to ExecutionService and MultichainRouter
FrederikBolding
previously approved these changes
Feb 4, 2025
packages/snaps-controllers/src/services/AbstractExecutionService.ts
Outdated
Show resolved
Hide resolved
FrederikBolding
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
nameandstatefield to theExecutionServiceandMultichainRouter, which is required for it to work with modular initialisation in the MetaMask extension.