feat: Add AccountSelector component
#3088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeRx
force-pushed
the
gr/account-selector
branch
from
c5fe4c3 to
ee67e9e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3088 +/- ##
==========================================
+ Coverage 98.14% 98.15% +0.01%
==========================================
Files 399 401 +2
Lines 10990 11068 +78
Branches 1729 1748 +19
==========================================
+ Hits 10786 10864 +78
Misses 204 204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuillaumeRx
force-pushed
the
gr/account-selector
branch
from
311858f to
b32f31a
Compare
GuillaumeRx
commented
Feb 12, 2025
Mrtenz
requested changes
Feb 13, 2025
packages/snaps-sdk/src/jsx/components/form/AccountSelector.test.tsx
Outdated
Show resolved
Hide resolved
packages/snaps-sdk/src/jsx/components/form/AccountSelector.test.tsx
Outdated
Show resolved
Hide resolved
GuillaumeRx
force-pushed
the
gr/account-selector
branch
from
0f3aca9 to
23230f6
Compare
GuillaumeRx
force-pushed
the
gr/account-selector
branch
from
23230f6 to
1e12de9
Compare
GuillaumeRx
force-pushed
the
gr/account-selector
branch
from
1e12de9 to
2d2003e
Compare
GuillaumeRx
force-pushed
the
gr/account-selector
branch
from
b50849d to
0f840ba
Compare
packages/snaps-controllers/src/interface/SnapInterfaceController.ts
Outdated
Show resolved
Hide resolved
GuillaumeRx
force-pushed
the
gr/account-selector
branch
from
f1c40d9 to
1e76a9e
Compare
packages/snaps-controllers/src/interface/SnapInterfaceController.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Frederik Bolding <[email protected]>
Co-authored-by: Frederik Bolding <[email protected]>
Co-authored-by: Frederik Bolding <[email protected]>
GuillaumeRx
force-pushed
the
gr/account-selector
branch
from
d0d7bde to
c3aec1c
Compare
FrederikBolding
approved these changes
May 22, 2025
Mrtenz
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new component called
AccountSelector.This component uses the account list of the client to display and select an account. The list can be filtered via the component props.
Progresses: #2810
Related extension PR: MetaMask/metamask-extension#30323