Skip to content

Update snap_getPreferences #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hmalik88 merged 13 commits into from
Feb 17, 2025
Merged

Update snap_getPreferences #3093

hmalik88 merged 13 commits into from
Feb 17, 2025

Conversation

@hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Feb 13, 2025

Updating snap_getPreferences return type to include additional properties.

Closes #3076

@hmalik88 hmalik88 marked this pull request as ready for review February 13, 2025 09:37
@hmalik88 hmalik88 requested a review from a team as a code owner February 13, 2025 09:37
Mrtenz
Mrtenz previously requested changes Feb 13, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Feb 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (f17d19d) to head (f4367df).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3093   +/-   ##
=======================================
  Coverage   94.88%   94.88%           
=======================================
  Files         506      506           
  Lines       11121    11121           
  Branches     1709     1709           
=======================================
  Hits        10552    10552           
  Misses        569      569

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

GuillaumeRx
GuillaumeRx reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@GuillaumeRx GuillaumeRx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't update snap-simulation, can we update it ?

@FrederikBolding
Copy link
Member

FrederikBolding commented Feb 13, 2025

This PR doesn't update snap-simulation, can we update it ?

Yes please, we can just return true for all the new flags tbh

@hmalik88
Copy link
Contributor Author

hmalik88 commented Feb 13, 2025

This PR doesn't update snap-simulation, can we update it ?

Done

FrederikBolding
FrederikBolding reviewed Feb 17, 2025
View reviewed changes
FrederikBolding
FrederikBolding reviewed Feb 17, 2025
View reviewed changes
packages/snaps-simulation/src/test-utils/options.ts
secretRecoveryPhrase = DEFAULT_SRP,
state = null,
unencryptedState = null,
useSecurityAlerts = true,
Copy link
Member

@FrederikBolding FrederikBolding Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now is the time I really wished we put these options somewhere else @Mrtenz 😅

FrederikBolding
FrederikBolding previously approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing due to snapshots being outdated, otherwise lgtm

@hmalik88 hmalik88 merged commit d7e2167 into main Feb 17, 2025
171 checks passed
@hmalik88 hmalik88 deleted the hm/update-get-preferences branch February 17, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeRx GuillaumeRx GuillaumeRx left review comments

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@Mrtenz Mrtenz Awaiting requested review from Mrtenz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add privacy-related settings to getPreferences

5 participants

@hmalik88 @FrederikBolding @Mrtenz @GuillaumeRx