Replace nested workspace configuration with top-level configuration #3094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3094 +/- ##
=======================================
Coverage 94.88% 94.88%
=======================================
Files 506 506
Lines 11123 11123
Branches 1709 1709
=======================================
Hits 10554 10554
Misses 569 569 ☔ View full report in Codecov by Sentry. |
GuillaumeRx
approved these changes
Feb 13, 2025
Mrtenz
added a commit
that referenced
this pull request
Feb 17, 2025
The build script for examples broke in #3094. Using the `filter` command seems to be the easiest way to get it working again.
Mrtenz
added a commit
that referenced
this pull request
Feb 25, 2025
`yarn start` in the `test-snaps` folder was broken after #3094. This fixes it.
Mrtenz
added a commit
that referenced
this pull request
Feb 25, 2025
`yarn start` in the `test-snaps` folder was broken after #3094. This fixes it.
Mrtenz
added a commit
to Mrtenz/snaps
that referenced
this pull request
Mar 13, 2025
…ration (MetaMask#3094)" This reverts commit 95076bf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the nested workspace configuration we use for examples with a top-level configuration. It seems that Dependabot doesn't support nested workspaces, resulting in lint errors that need to be manually fixed. Hopefully this change addresses that issue.