-
Notifications
You must be signed in to change notification settings - Fork 639
Add AddressInput component
#3129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3129 +/- ##
=======================================
Coverage 94.98% 94.98%
=======================================
Files 510 511 +1
Lines 11303 11314 +11
Branches 1750 1754 +4
=======================================
+ Hits 10736 10747 +11
Misses 567 567 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuillaumeRx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The state shape of the AddressInput component is a CAIP-10 account ID. When a value prop is passed to the component we should construct the CAIP-10 account ID in state with the chainId prop.
Updated the state |
GuillaumeRx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the type of the state to include CaipAccountIdStruct
GuillaumeRx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, waiting for an extension PR
41a015b to
613ec91
Compare
Closes #2812
This adds an
AddressInputcomponent that takes a CAIP-2chainIdto identify the chain the address needs resolution on and resolves to a display name and avatar (if it exists). The resolution is to be made against the user's own saved accounts.