Skip to content

Conversation

@hmalik88
Copy link
Contributor

Closes #2812

This adds an AddressInput component that takes a CAIP-2 chainId to identify the chain the address needs resolution on and resolves to a display name and avatar (if it exists). The resolution is to be made against the user's own saved accounts.

@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.98%. Comparing base (099030b) to head (fb343af).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3129   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files         510      511    +1     
  Lines       11303    11314   +11     
  Branches     1750     1754    +4     
=======================================
+ Hits        10736    10747   +11     
  Misses        567      567           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hmalik88 hmalik88 marked this pull request as ready for review February 18, 2025 23:59
@hmalik88 hmalik88 requested a review from a team as a code owner February 18, 2025 23:59
Copy link
Contributor

@GuillaumeRx GuillaumeRx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The state shape of the AddressInput component is a CAIP-10 account ID. When a value prop is passed to the component we should construct the CAIP-10 account ID in state with the chainId prop.

@hmalik88
Copy link
Contributor Author

The state shape of the AddressInput component is a CAIP-10 account ID. When a value prop is passed to the component we should construct the CAIP-10 account ID in state with the chainId prop.

Updated the state

Copy link
Contributor

@GuillaumeRx GuillaumeRx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the type of the state to include CaipAccountIdStruct

Copy link
Contributor

@GuillaumeRx GuillaumeRx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, waiting for an extension PR

Mrtenz
Mrtenz previously requested changes Feb 27, 2025
@hmalik88 hmalik88 requested a review from Mrtenz March 11, 2025 18:48
@GuillaumeRx GuillaumeRx enabled auto-merge March 21, 2025 11:30
@GuillaumeRx GuillaumeRx removed the request for review from Mrtenz March 21, 2025 11:43
@GuillaumeRx GuillaumeRx added this pull request to the merge queue Mar 21, 2025
Merged via the queue into main with commit b923057 Mar 21, 2025
173 checks passed
@GuillaumeRx GuillaumeRx deleted the hm/add-address-input branch March 21, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement AddressInput component

6 participants