fix: Log unhandled Snap errors #3157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3157 +/- ##
=======================================
Coverage 94.91% 94.91%
=======================================
Files 504 504
Lines 11133 11134 +1
Branches 1711 1711
=======================================
+ Hits 10567 10568 +1
Misses 566 566 ☔ View full report in Codecov by Sentry. |
Mrtenz
reviewed
Feb 25, 2025
Mrtenz
approved these changes
Feb 25, 2025
Co-authored-by: Maarten Zuidhoorn <[email protected]>
FrederikBolding
force-pushed
the
fb/log-unhandled-errors
branch
from
fc99334 to
e69b119
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log unhandled Snap errors for easier debugging when a Snap is crashing. This lets developers dig up the actual reason for their Snap being terminated in the logs.