Skip to content

Conversation

@hmalik88
Copy link
Contributor

Updated the send flow example snap to use the new AddressInput component.

@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.98%. Comparing base (e859203) to head (261ca7d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3167   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files         511      511           
  Lines       11300    11300           
  Branches     1737     1737           
=======================================
  Hits        10733    10733           
  Misses        567      567           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

eriknson

This comment was marked as outdated.

placeholder="Enter receiving address"
value={flushToAddress ? '' : undefined}
/>
{displayClearIcon && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AddressInput component has a clear icon built-in.

@hmalik88 hmalik88 requested a review from Mrtenz March 11, 2025 18:48
@hmalik88 hmalik88 marked this pull request as ready for review March 24, 2025 15:25
@hmalik88 hmalik88 requested a review from a team as a code owner March 24, 2025 15:25
@hmalik88 hmalik88 changed the title Update send flow snap Update send flow snap to use new AddressInput component Mar 24, 2025
@FrederikBolding FrederikBolding dismissed eriknson’s stale review March 24, 2025 15:34

Review on the wrong PR it seems

@FrederikBolding FrederikBolding added this pull request to the merge queue Mar 24, 2025
Merged via the queue into main with commit a270b30 Mar 24, 2025
173 checks passed
@FrederikBolding FrederikBolding deleted the hm/update-send-flow-snap branch March 24, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants