Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Feb 28, 2025

I've made some minor changes to test-snaps related to the SIP-30 entropy selector.

  • Each selector now has a unique ID. Previously the same ID was shared by multiple components, which is semantically incorrect HTML, and also makes it more difficult to E2E test.
  • I've added an "invalid" option to the selector, to test that we properly throw errors for entropy sources that don't exist.

@Mrtenz Mrtenz requested a review from a team as a code owner February 28, 2025 11:47
david0xd
david0xd previously approved these changes Feb 28, 2025
@codecov
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.93%. Comparing base (06798b3) to head (10fd543).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3172   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files         507      507           
  Lines       11184    11184           
  Branches     1722     1722           
=======================================
  Hits        10618    10618           
  Misses        566      566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz Mrtenz added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit 0ee1f83 Feb 28, 2025
123 checks passed
@Mrtenz Mrtenz deleted the mrtenz/sip-30-test-snaps branch February 28, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants