Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Mar 7, 2025

update-chrome is a requirement for commit-result, but it turns out that if update-chrome is skipped, so is commit-result. Adding the if condition makes the job always run (assuming it didn't fail or didn't get cancelled).

@Mrtenz Mrtenz requested a review from a team as a code owner March 7, 2025 13:31
@codecov
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.93%. Comparing base (dc44861) to head (b46e4f2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3208   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files         507      507           
  Lines       11185    11185           
  Branches     1722     1722           
=======================================
  Hits        10619    10619           
  Misses        566      566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mrtenz Mrtenz added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit d2c99e6 Mar 7, 2025
123 checks passed
@Mrtenz Mrtenz deleted the mrtenz/always-commit-result branch March 7, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants