Update workflows to use MetaMask/action-checkout-and-setup
#3214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3214 +/- ##
=======================================
Coverage 94.93% 94.93%
=======================================
Files 507 507
Lines 11185 11185
Branches 1722 1722
=======================================
Hits 10619 10619
Misses 566 566 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@metamaskbot update-pr |
| - prepare | ||
| - dedupe-yarn-lock | ||
| steps: | ||
| - name: Checkout repository |
Member
There was a problem hiding this comment.
I don't fully follow the logic here, we are running checkout, then gh pr checkout and then the MetaMask checkout action too?
Member
Author
There was a problem hiding this comment.
actions/checkout to allow checking out the PR, then MetaMask/action-checkout-and-setup to install dependencies and handle caching. It skips the checkout step if the files are already there.
| run: yarn workspace @metamask/snaps-simulator run build:vendor | ||
| - name: Build | ||
| run: yarn workspace @metamask/snaps-simulator run build:webpack | ||
| - name: Cache "@metamask/snaps-simulator" build |
Member
There was a problem hiding this comment.
What was this used for before?
Member
Author
There was a problem hiding this comment.
To run snaps-jest, but we didn't remove this when switching to the Node.js-based simulation.
FrederikBolding
approved these changes
Mar 12, 2025
4 tasks
Mrtenz
added a commit
to MetaMask/core
that referenced
this pull request
Mar 14, 2025
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> This updates all workflows to remove the use of `actions/checkout`, `actions/setup-node`, `actions/cache`. The implementation here is based on MetaMask/snaps#3214. ## References MetaMask-planning#3925. ## Changelog n/a, this doesn't make any changes to packages directly. ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all workflows to use
MetaMask/action-checkout-and-setupand remove the use ofactions/cache.