Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Mar 12, 2025

This PR adjusts the implementations of the entropy RPC methods to use getMnemonicSeed if the curve being used is either secp256k1 or ed25519. This let's us skip the most computationally heavy part of the key derivation by re-using the already derived BIP-39 seed.

Closes #3219

Breaking changes

  • A getMnemonicSeed hook is now required to support all entropy RPC methods.
    • Note that getMnemonic can not be removed as that is still also in use.

@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.93%. Comparing base (74a2526) to head (b8460e9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/snaps-simulator/src/features/simulation/sagas.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3220      +/-   ##
==========================================
- Coverage   94.94%   94.93%   -0.01%     
==========================================
  Files         507      508       +1     
  Lines       11195    11219      +24     
  Branches     1723     1730       +7     
==========================================
+ Hits        10629    10651      +22     
- Misses        566      568       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from fb/use-mnemonic-seed-for-state-persistence to main March 13, 2025 09:18
@FrederikBolding FrederikBolding force-pushed the fb/use-mnemonic-seed-for-entropy branch from 055b888 to 874c2f8 Compare March 13, 2025 09:20
@FrederikBolding FrederikBolding marked this pull request as ready for review March 13, 2025 09:22
@FrederikBolding FrederikBolding requested a review from a team as a code owner March 13, 2025 09:22
@FrederikBolding FrederikBolding added this pull request to the merge queue Mar 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2025
@FrederikBolding FrederikBolding added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit 1f5ae17 Mar 13, 2025
173 checks passed
@FrederikBolding FrederikBolding deleted the fb/use-mnemonic-seed-for-entropy branch March 13, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use mnemonic seed for key derivation where applicable

3 participants