Skip to content

Conversation

@Marcofann
Copy link
Contributor

@Marcofann Marcofann commented Mar 17, 2025

Fixed incorrect terminology:

  • "Network ID as per EIP-155""Chain ID as per EIP-155" (EIP-155 defines chainId, not network ID).

Fixed spelling mistake:

  • "Maxmimum""Maximum".

@Marcofann Marcofann requested a review from a team as a code owner March 17, 2025 16:37
@Marcofann
Copy link
Contributor Author

@Mrtenz , I’ve reverted the nonce type back to string to match internal usage.
Let me know if anything else needs updating!

@Mrtenz Mrtenz changed the title Fix documentation and typing in TransactionParams Fix typo in documentation in TransactionParams Apr 23, 2025
@Mrtenz Mrtenz added this pull request to the merge queue Apr 23, 2025
Merged via the queue into MetaMask:main with commit b8792af Apr 23, 2025
170 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants