Skip to content

Conversation

@FrederikBolding
Copy link
Member

Before this PR we would sometimes (every 5 minutes or so) update the phishing list before validating interfaces. When the phishing list is out of date it takes multiple seconds for this call to resolve causing an unacceptable experience.

From now on, we will assume that the phishing list is kept up to date by other controllers (or the user visiting dapps for instance).

@FrederikBolding FrederikBolding requested a review from a team as a code owner March 27, 2025 15:12
Copy link
Contributor

@hmalik88 hmalik88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to me, our platform shouldn't need to ensure other lists are UTD.

@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.98%. Comparing base (eb408a3) to head (92de5e4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3272      +/-   ##
==========================================
- Coverage   94.98%   94.98%   -0.01%     
==========================================
  Files         511      511              
  Lines       11305    11299       -6     
  Branches     1738     1738              
==========================================
- Hits        10738    10732       -6     
  Misses        567      567              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue Mar 27, 2025
Merged via the queue into main with commit fdc83e1 Mar 27, 2025
172 checks passed
@FrederikBolding FrederikBolding deleted the fb/dont-refresh-phishing-list-when-updating-interfaces branch March 27, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants