Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Apr 1, 2025

As per request from the wallet API team and after discussion with them we want to consider protocol Snaps when determining the return value of isSupportedScope. Previously we assumed that a scope was not serviceable if no accounts existed, but that isn't entirely accurate enough.

@FrederikBolding FrederikBolding force-pushed the fb/add-protocol-snap-to-is-supported-scope branch from d63fc21 to 8f0e266 Compare April 2, 2025 15:03
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.87%. Comparing base (8bfaf95) to head (c73ab11).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3284   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files         517      517           
  Lines       11335    11336    +1     
  Branches     1749     1750    +1     
=======================================
+ Hits        10754    10755    +1     
  Misses        581      581           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding marked this pull request as ready for review April 2, 2025 16:19
@FrederikBolding FrederikBolding requested a review from a team as a code owner April 2, 2025 16:19
@FrederikBolding FrederikBolding added this pull request to the merge queue Apr 3, 2025
@FrederikBolding FrederikBolding changed the title fix: Consider protocol Snaps when determining isSupportedScope fix: Consider protocol Snaps when determining isSupportedScope Apr 3, 2025
Merged via the queue into main with commit 48f76da Apr 3, 2025
172 checks passed
@FrederikBolding FrederikBolding deleted the fb/add-protocol-snap-to-is-supported-scope branch April 3, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants