Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Apr 2, 2025

We were using empty origins in a lot of places instead of specifying metamask for internal requests. This PR disallows doing that so we can be clear about where requests are coming from. origin must now be either a valid URL or metamask.

@FrederikBolding FrederikBolding changed the title fix: Disallow empty origins fix: Validate origin in handleRequest Apr 2, 2025
@FrederikBolding FrederikBolding marked this pull request as ready for review April 2, 2025 11:51
@FrederikBolding FrederikBolding requested a review from a team as a code owner April 2, 2025 11:51
@FrederikBolding FrederikBolding force-pushed the fb/disallow-empty-origins branch from caffdd6 to 8c8c495 Compare April 2, 2025 12:09
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.87%. Comparing base (1760a18) to head (8c8c495).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3292   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files         517      517           
  Lines       11333    11335    +2     
  Branches     1748     1749    +1     
=======================================
+ Hits        10752    10754    +2     
  Misses        581      581           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit 92f9962 Apr 2, 2025
172 checks passed
@FrederikBolding FrederikBolding deleted the fb/disallow-empty-origins branch April 2, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants