Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Apr 3, 2025

Inject context into onUserInput requests, this reduces complexity on the client-side where the UI system no longer has to keep context up to date. Also fixes a problem where we weren't keeping the context properly up to date.

Fixes #3069

@FrederikBolding FrederikBolding force-pushed the fb/inject-context-in-interface-calls branch from 5cc6733 to 4b80009 Compare April 3, 2025 10:39
@FrederikBolding FrederikBolding marked this pull request as ready for review April 3, 2025 10:39
@FrederikBolding FrederikBolding requested a review from a team as a code owner April 3, 2025 10:39
@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.73%. Comparing base (7e6ad03) to head (676be73).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3298   +/-   ##
=======================================
  Coverage   94.72%   94.73%           
=======================================
  Files         518      518           
  Lines       11932    11941    +9     
  Branches     1831     1834    +3     
=======================================
+ Hits        11303    11312    +9     
  Misses        629      629           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding force-pushed the fb/inject-context-in-interface-calls branch from 4b80009 to 676be73 Compare April 3, 2025 11:37
@FrederikBolding FrederikBolding added this pull request to the merge queue Apr 3, 2025
Merged via the queue into main with commit 0ba61f0 Apr 3, 2025
173 checks passed
@FrederikBolding FrederikBolding deleted the fb/inject-context-in-interface-calls branch April 3, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Context may get out of sync if the context is changed without the content changing

3 participants