-
Notifications
You must be signed in to change notification settings - Fork 639
feat: Add snaps-sandbox package and integrate into CLI
#3306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| export var walkTokens = (__marked_exports.walkTokens || exports.walkTokens); | ||
| // ESM-uncomment-end | ||
| - | ||
| -//# sourceMappingURL=marked.umd.js.map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This source map doesn't exist, and Vite was complaining about it.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution Review the following alerts detected in dependencies. According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. Learn more about Socket for GitHub.
Ignoring alerts on: |
|
@SocketSecurity ignore npm/[email protected] False positive. @SocketSecurity ignore npm/[email protected] These seem fine. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3306 +/- ##
==========================================
+ Coverage 97.80% 98.03% +0.23%
==========================================
Files 364 402 +38
Lines 9911 11111 +1200
Branches 1616 1754 +138
==========================================
+ Hits 9693 10893 +1200
Misses 218 218 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8fcb57c to
ece3569
Compare
snaps-sandbox package and integrate into CLIsnaps-sandbox package and integrate into CLI
|
@SocketSecurity ignore [email protected] New author is ok. |
GuillaumeRx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit otherwise LGTM
| mm-snap build Build snap from source [aliases: b] | ||
| mm-snap eval Attempt to evaluate snap bundle in SES [aliases: e] | ||
| mm-snap manifest Validate the snap.manifest.json file [aliases: m] | ||
| mm-snap sandbox Start a sandbox server to interact with the Snap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No alias for this one ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s was already taken, and I'm not sure what else to use 😅 And in general I don't think we really need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x?
This adds a new package,
@metamask/snaps-sandbox, which is a tool to interact with Snaps through a web app. It's a replacement for the Snaps Simulator, but doesn't simulate any functionality. Instead, it calls MetaMask through the usual JSON-RPC methods.The sandbox can be used from the Snaps CLI by running
mm-snap sandbox.