fix: Make comparision case sensitive in MultichainRouter #3310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeRx
previously approved these changes
Apr 9, 2025
Contributor
|
Should we had a test case for that ? |
Mrtenz
requested changes
Apr 9, 2025
Member
Mrtenz
left a comment
Mrtenz
left a comment
There was a problem hiding this comment.
Please add a test and update relevant documentation.
Mrtenz
reviewed
Apr 9, 2025
packages/snaps-controllers/src/multichain/MultichainRouter.test.ts
Outdated
Show resolved
Hide resolved
…t.ts Co-authored-by: Maarten Zuidhoorn <[email protected]>
Mrtenz
approved these changes
Apr 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3310 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 518 518
Lines 11947 11947
Branches 1836 1836
=======================================
Hits 11318 11318
Misses 629 629 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As non-EVM accounts may be case sensitive, we cannot use
toLowerCasefor address comparision. This PR makes theMultichainRouteruse case sensitive comparison instead.