perf: Stop encoding messages in mobile #3347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3347 +/- ##
==========================================
- Coverage 98.03% 98.03% -0.01%
==========================================
Files 402 402
Lines 11112 11110 -2
Branches 1754 1754
==========================================
- Hits 10894 10892 -2
Misses 218 218 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
weizman
reviewed
Apr 24, 2025
|
|
||
| const json = bytesToString(new Uint8Array(event.data as number[])); | ||
| const message = JSON.parse(json); | ||
| const message = JSON.parse(event.data); |
Contributor
There was a problem hiding this comment.
this can throw, should we catch gracefully?
Member
Author
There was a problem hiding this comment.
I don't think it matters too much, we don't do it in any of the other post message stream implementations used in MM either 😄
Mrtenz
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach for message passing in mobile encodes the JSON payloads into a byte array before injecting into the WebView. This was done by suggestion from @naugtur, but was known to be slow on mobile, especially with larger messages.
More recently this caused performance degradations with Snaps that MetaMask is actively trying to ship to production causing us to revisit this. After discussion with @weizman we landed on the fact that simply JSON stringifying should be safe enough and much more performant.