chore!: Make interface actions synchronous #3361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interface actions used to be required to be asynchronous, this is no longer the case.
Note
Convert Snap interface create/update flows from async to sync across controllers, RPC handlers, simulation hooks, and tests.
SnapInterfaceController#createInterface,updateInterface, and private#validateContentsynchronous; removeawaitusage.snap_createInterfaceandsnap_updateInterfaceimplementations and hook types to return synchronously (noPromise).createInterface/updateInterfacesynchronous; adjustgetInterfaceFromResultto call controller withoutawait.awaitfrom synchronous calls; switch async rejection assertions to synchronous.toThrowwhere applicable; update usages across controller, simulation, and request tests.Written by Cursor Bugbot for commit c8e8a1b. This will update automatically on new commits. Configure here.