Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Apr 28, 2025

Interface actions used to be required to be asynchronous, this is no longer the case.


Note

Convert Snap interface create/update flows from async to sync across controllers, RPC handlers, simulation hooks, and tests.

  • Controllers:
    • Make SnapInterfaceController#createInterface, updateInterface, and private #validateContent synchronous; remove await usage.
  • RPC Methods:
    • Update snap_createInterface and snap_updateInterface implementations and hook types to return synchronously (no Promise).
  • Simulation:
    • Make permitted hooks createInterface/updateInterface synchronous; adjust getInterfaceFromResult to call controller without await.
  • Tests:
    • Remove await from synchronous calls; switch async rejection assertions to synchronous .toThrow where applicable; update usages across controller, simulation, and request tests.

Written by Cursor Bugbot for commit c8e8a1b. This will update automatically on new commits. Configure here.

@FrederikBolding FrederikBolding requested a review from a team as a code owner April 28, 2025 11:42
@Mrtenz Mrtenz changed the title chore: Make interface actions synchronous chore!: Make interface actions synchronous Apr 28, 2025
@FrederikBolding FrederikBolding force-pushed the fb/make-interface-actions-sync branch from 047bcb4 to 037491b Compare October 1, 2025 14:38
@FrederikBolding FrederikBolding requested a review from a team as a code owner October 1, 2025 14:38
Mrtenz
Mrtenz previously approved these changes Oct 1, 2025
@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.29%. Comparing base (8571a4d) to head (c8e8a1b).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3361      +/-   ##
==========================================
+ Coverage   98.27%   98.29%   +0.01%     
==========================================
  Files         417      417              
  Lines       11903    11907       +4     
  Branches     1845     1848       +3     
==========================================
+ Hits        11698    11704       +6     
+ Misses        205      203       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue Oct 2, 2025
Merged via the queue into main with commit 604e87b Oct 2, 2025
121 checks passed
@FrederikBolding FrederikBolding deleted the fb/make-interface-actions-sync branch October 2, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants