Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented May 2, 2025

This is a redo of #3357, which was reverted in #3359 to avoid two breaking changes in a row. Now that #3322 is merged, we can do this again.

The original PR description can be found below.


This removes the web worker execution service and execution environment, as they were unused. We can revert this PR in the future to add them again, if needed.

Breaking changes

@metamask/snaps-controllers

  • Remove web worker execution service.

@metamask/snaps-execution-environments

  • Remove web worker pool execution environment.
  • Remove web worker executor execution environment.

@codecov
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.04%. Comparing base (1d36a99) to head (9861942).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3371    +/-   ##
========================================
  Coverage   98.03%   98.04%            
========================================
  Files         402      398     -4     
  Lines       11107    10951   -156     
  Branches     1754     1725    -29     
========================================
- Hits        10889    10737   -152     
+ Misses        218      214     -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mrtenz Mrtenz marked this pull request as ready for review May 2, 2025 12:16
@Mrtenz Mrtenz requested a review from a team as a code owner May 2, 2025 12:16
@Mrtenz Mrtenz added this pull request to the merge queue May 2, 2025
Merged via the queue into main with commit 5c41495 May 2, 2025
119 checks passed
@Mrtenz Mrtenz deleted the mrtenz/cherry-pick-remove-web-workers branch May 2, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants