Skip to content

Conversation

@FrederikBolding
Copy link
Member

The MultichainRouter incorrectly passes on params that could be undefined, this PR fixes that.

@FrederikBolding FrederikBolding requested a review from a team as a code owner May 13, 2025 11:32
@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (ee0c1f3) to head (38f1ddf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3388   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files         398      398           
  Lines       10966    10967    +1     
  Branches     1724     1725    +1     
=======================================
+ Hits        10755    10756    +1     
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

GuillaumeRx
GuillaumeRx previously approved these changes May 13, 2025
@GuillaumeRx
Copy link
Contributor

Nit: Could we have a test to ensure we don't pass undefined ?

@FrederikBolding
Copy link
Member Author

Nit: Could we have a test to ensure we don't pass undefined ?

Added an assertion to an existing test!

@FrederikBolding FrederikBolding added this pull request to the merge queue May 13, 2025
Merged via the queue into main with commit cc57e61 May 13, 2025
115 checks passed
@FrederikBolding FrederikBolding deleted the fb/remove-undefined-params-in-multichainrouter branch May 13, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants