-
Notifications
You must be signed in to change notification settings - Fork 639
feat: Implement SIP-31 #3394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: Implement SIP-31 #3394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3394 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 398 398
Lines 10966 10976 +10
Branches 1724 1728 +4
=======================================
+ Hits 10755 10765 +10
Misses 211 211 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuillaumeRx
previously approved these changes
May 15, 2025
Mrtenz
requested changes
May 15, 2025
Co-authored-by: Maarten Zuidhoorn <[email protected]>
Mrtenz
previously approved these changes
May 15, 2025
Mrtenz
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
onClientRequesthandler as specified in SIP-31. This handler can only be called by MetaMask and is available to all Snaps without permission. It can be used for general purpose communication that must not be exposed to dapps (asonRpcRequest).This handler is enforced to only be callable by the
metamaskorigin, as part of this PR this same validation is applied to all handlers inCLIENT_ONLY_HANDLERS.Closes #3392