Skip to content

Conversation

@FrederikBolding
Copy link
Member

This PR fixes an issue with scheduling background events using durations. Since we were truncating durations to remove milliseconds we would effectively allow scheduling events less than 1 second into the future.

To work around this, durations are now allowed to be a minimum of 1 second and are untruncated. The execution date will still be truncated when the Snap requests it to prevent leakage of millisecond precision.

@FrederikBolding FrederikBolding requested a review from a team as a code owner May 21, 2025 14:21
@FrederikBolding FrederikBolding force-pushed the fb/fix-background-events-bugs branch from 5765b2f to d76b914 Compare May 21, 2025 14:27
@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.12%. Comparing base (4acb5c3) to head (e3b606e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3414   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files         399      399           
  Lines       10961    10967    +6     
  Branches     1725     1727    +2     
=======================================
+ Hits        10755    10761    +6     
  Misses        206      206           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
@FrederikBolding FrederikBolding enabled auto-merge May 22, 2025 08:45
@FrederikBolding FrederikBolding added this pull request to the merge queue May 22, 2025
Merged via the queue into main with commit e101e0f May 22, 2025
117 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-background-events-bugs branch May 22, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants