feat: Add onProtocolRequest to snaps-jest
#3422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
reviewed
May 27, 2025
FrederikBolding
commented
May 27, 2025
| method: 'getBlockHeight', | ||
| }); | ||
|
|
||
| expect(response).toRespondWith(expect.any(Number)); |
Member
Author
There was a problem hiding this comment.
Would be nice to have network mocking here :/
Member
There was a problem hiding this comment.
I agree, but there's no easy way to hook into the fetch function since it's run in a separate thread 😞
Mrtenz
approved these changes
May 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3422 +/- ##
=======================================
Coverage 98.16% 98.16%
=======================================
Files 402 402
Lines 11109 11116 +7
Branches 1753 1755 +2
=======================================
+ Hits 10905 10912 +7
Misses 204 204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
onProtocolRequesttosnaps-jest, also adds a test to the protocol example Snap.Closes #3187