fix: Unwrap double-wrapped JSON-RPC errors#3432
Merged
FrederikBolding merged 2 commits intomainfrom Jun 4, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3432 +/- ##
=======================================
Coverage 98.16% 98.16%
=======================================
Files 402 402
Lines 11116 11123 +7
Branches 1755 1759 +4
=======================================
+ Hits 10912 10919 +7
Misses 204 204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mrtenz
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Snap may return a double-wrapped JSON-RPC error if it uses a JSON-RPC method that throws. In that case we currently do not unwrap it properly but instead return an error without a stack trace, this makes it unreadable in
snaps-jestand is just generally not what we want to do. This PR unwraps this type of error to supply the stack trace.