Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jun 13, 2025

This adds a new lifecycle hook "onStart", to be called when the client starts. The Snap can use this to perform any initialisation needed, such as setting up a WebSocket connection or background event.

Closes #3453.

@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (443340f) to head (15812a5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3455   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files         404      404           
  Lines       11317    11334   +17     
  Branches     1764     1766    +2     
=======================================
+ Hits        11115    11132   +17     
  Misses        202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mrtenz Mrtenz marked this pull request as ready for review June 13, 2025 13:35
@Mrtenz Mrtenz requested a review from a team as a code owner June 13, 2025 13:35
@Mrtenz Mrtenz force-pushed the mrtenz/on-start-lifecycle-hook branch from 9b8ba0b to 15812a5 Compare June 17, 2025 08:51
@FrederikBolding FrederikBolding added this pull request to the merge queue Jun 17, 2025
Merged via the queue into main with commit 102e818 Jun 17, 2025
117 checks passed
@FrederikBolding FrederikBolding deleted the mrtenz/on-start-lifecycle-hook branch June 17, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add lifecycle hook that's called when the client is started

3 participants